Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 1038 #1039

Merged
merged 1 commit into from
Oct 20, 2020
Merged

fix issue 1038 #1039

merged 1 commit into from
Oct 20, 2020

Conversation

ycohen-dev
Copy link
Contributor

Replaced gravity pinning to "end" instead of "right"
Pinned claim id which could be in rtl and ltr scripts to the start of the layout

PR Checklist

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

Fixes

Issue Number: 1038

What is the current behavior?

Claim ID misaligned with transaction description in Recent Transaction/T. History

What is the new behavior?

Claim ID aligned with transaction description

Screenshots

claim_id_rtl_fixed

Replaced gravity pinning to "end" instead of "right"
Pinned claim id which could be in rtl and ltr scripts to the start of the layout
Copy link
Contributor

@akinwale akinwale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@lbry-bot lbry-bot assigned akinwale and unassigned akinwale Oct 20, 2020
@akinwale akinwale merged commit fc64918 into lbryio:master Oct 20, 2020
@ycohen-dev ycohen-dev deleted the fix_issue_1038 branch October 21, 2020 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants