Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort replies from oldest to newest #1057

Merged
merged 1 commit into from
Dec 5, 2020

Conversation

kekkyojin
Copy link
Collaborator

PR Checklist

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

Fixes

Issue Number: #948

What is the current behavior?

Replies to comments are ordered in a way which newest ones appear first, making difficult to follow the conversation if there are lots of replies, as it requires to scroll down to the latest one and then scrolling up while reading adn then scrolling down again to read next comment.

What is the new behavior?

Replies are ordered on its chronological order: older are shown first and followed by newer ones.

New behavior is also consistent with LBRY.TV and ODYSEE.COM. See for example https://lbry.tv/microsoft:2. Replies from the comments are the bottom are now shown in the same order in both the site and LBRY Android app.

@kauffj
Copy link
Member

kauffj commented Dec 4, 2020

Review coming soon! Thank you

Copy link
Contributor

@akinwale akinwale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thanks!

@lbry-bot lbry-bot assigned akinwale and unassigned akinwale Dec 5, 2020
@akinwale akinwale merged commit 68ac64b into lbryio:master Dec 5, 2020
@kekkyojin kekkyojin deleted the sort-commentreplies branch December 7, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants