Skip to content

Commit

Permalink
remove video files; save video claimId rather than URI
Browse files Browse the repository at this point in the history
  • Loading branch information
daovist committed Dec 29, 2017
1 parent 61b8e8e commit a8988d9
Show file tree
Hide file tree
Showing 9 changed files with 23 additions and 59 deletions.
6 changes: 2 additions & 4 deletions src/renderer/component/video/index.js
Expand Up @@ -4,7 +4,6 @@ import { doChangeVolume } from "redux/actions/app";
import { selectVolume } from "redux/selectors/app";
import { doPlayUri, doSetPlayingUri } from "redux/actions/content";
import { doPlay, doPause, savePosition } from "redux/actions/media";
// import { setVideoPause } from "redux/actions/video";
import {
makeSelectMetadataForUri,
makeSelectContentTypeForUri,
Expand All @@ -16,15 +15,16 @@ import {
} from "redux/selectors/file_info";
import { makeSelectCostInfoForUri } from "redux/selectors/cost_info";
import { selectShowNsfw } from "redux/selectors/settings";
// import { selectVideoPause } from "redux/selectors/video";
import {
selectMediaPaused,
makeSelectMediaPositionForUri,
} from "redux/selectors/media";
import Video from "./view";
import { selectPlayingUri } from "redux/selectors/content";
import { makeSelectClaimForUri } from "redux/selectors/claims";

const select = (state, props) => ({
claim: makeSelectClaimForUri(props.uri)(state),
costInfo: makeSelectCostInfoForUri(props.uri)(state),
fileInfo: makeSelectFileInfoForUri(props.uri)(state),
metadata: makeSelectMetadataForUri(props.uri)(state),
Expand All @@ -34,7 +34,6 @@ const select = (state, props) => ({
playingUri: selectPlayingUri(state),
contentType: makeSelectContentTypeForUri(props.uri)(state),
volume: selectVolume(state),
// videoPause: selectVideoPause(state),
mediaPaused: selectMediaPaused(state),
mediaPosition: makeSelectMediaPositionForUri(props.uri)(state),
});
Expand All @@ -43,7 +42,6 @@ const perform = dispatch => ({
play: uri => dispatch(doPlayUri(uri)),
cancelPlay: () => dispatch(doSetPlayingUri(null)),
changeVolume: volume => dispatch(doChangeVolume(volume)),
// setVideoPause: val => dispatch(setVideoPause(val)),
doPlay: () => dispatch(doPlay()),
doPause: () => dispatch(doPause()),
savePosition: (id, position) => dispatch(savePosition(id, position)),
Expand Down
6 changes: 4 additions & 2 deletions src/renderer/component/video/internal/player.jsx
Expand Up @@ -34,10 +34,12 @@ class VideoPlayer extends React.PureComponent {
mediaType,
changeVolume,
volume,
mediaId,
position,
id,
} = this.props;

console.log("position:", position);

const loadedMetadata = e => {
this.setState({ hasMetadata: true, startedPlaying: true });
this.refs.media.children[0].play();
Expand Down Expand Up @@ -74,7 +76,7 @@ class VideoPlayer extends React.PureComponent {
mediaElement.addEventListener("play", () => this.props.doPlay());
mediaElement.addEventListener("pause", () => this.props.doPause());
mediaElement.addEventListener("timeupdate", () =>
this.props.savePosition(mediaId, mediaElement.currentTime)
this.props.savePosition(id, mediaElement.currentTime)
);
mediaElement.addEventListener("click", this.togglePlayListener);
mediaElement.addEventListener(
Expand Down
8 changes: 4 additions & 4 deletions src/renderer/component/video/view.jsx
Expand Up @@ -55,6 +55,7 @@ class Video extends React.PureComponent {
contentType,
changeVolume,
volume,
claim,
uri,
doPlay,
doPause,
Expand All @@ -63,6 +64,8 @@ class Video extends React.PureComponent {
mediaPosition,
} = this.props;

console.log("mediaPosition:", mediaPosition);

const isPlaying = playingUri === uri;
const isReadyToPlay = fileInfo && fileInfo.written_bytes > 0;
const obscureNsfw = this.props.obscureNsfw && metadata && metadata.nsfw;
Expand Down Expand Up @@ -96,9 +99,6 @@ class Video extends React.PureComponent {
}
const poster = metadata.thumbnail;

const mediaId = uri.split("#")[1];
console.log("mediaId:", mediaId);

return (
<div
className={klasses.join(" ")}
Expand All @@ -121,7 +121,7 @@ class Video extends React.PureComponent {
doPlay={doPlay}
doPause={doPause}
savePosition={savePosition}
mediaId={mediaId}
id={claim.claim_id}
paused={mediaPaused}
position={mediaPosition}
/>
Expand Down
10 changes: 0 additions & 10 deletions src/renderer/redux/actions/video.js

This file was deleted.

4 changes: 3 additions & 1 deletion src/renderer/redux/reducers/media.js
Expand Up @@ -4,7 +4,9 @@ import { handleActions } from "util/redux-utils";

export type MediaState = {
paused: Boolean,
positions: Object,
positions: {
[string]: number,
},
};

export type Action = any;
Expand Down
25 changes: 0 additions & 25 deletions src/renderer/redux/reducers/video.js

This file was deleted.

12 changes: 10 additions & 2 deletions src/renderer/redux/selectors/media.js
@@ -1,5 +1,6 @@
import * as settings from "constants/settings";
import { createSelector } from "reselect";
import lbryuri from "lbryuri";

const _selectState = state => state.media || {};

Expand All @@ -10,6 +11,13 @@ export const selectMediaPaused = createSelector(

export const makeSelectMediaPositionForUri = uri =>
createSelector(_selectState, state => {
const id = uri.split("#")[1];
return state.positions[id] || null;
// console.log("select positions:", state.positions);
// const videoId = lbryuri.parse(uri).claimId;
// console.log("videoId:", videoId);
// const position = state.positions[videoId];
// console.log("position:", position);
// console.log("positions:", state.positions);
const obj = lbryuri.parse(uri);
console.log("state.positions:\n", state.positions);
return state.positions[obj.claimId] || null;
});
9 changes: 0 additions & 9 deletions src/renderer/redux/selectors/video.js

This file was deleted.

2 changes: 0 additions & 2 deletions src/renderer/store.js
Expand Up @@ -13,7 +13,6 @@ import userReducer from "redux/reducers/user";
import walletReducer from "redux/reducers/wallet";
import shapeShiftReducer from "redux/reducers/shape_shift";
import subscriptionsReducer from "redux/reducers/subscriptions";
import videoReducer from "redux/reducers/video";
import mediaReducer from "redux/reducers/media";
import { persistStore, autoRehydrate } from "redux-persist";
import createCompressor from "redux-persist-transform-compress";
Expand Down Expand Up @@ -71,7 +70,6 @@ const reducers = combineReducers({
user: userReducer,
shapeShift: shapeShiftReducer,
subscriptions: subscriptionsReducer,
video: videoReducer,
media: mediaReducer,
});

Expand Down

0 comments on commit a8988d9

Please sign in to comment.