Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If claim search on latter page fails, don't clear out all previous data #4609

Closed
tzarebczan opened this issue Jul 30, 2020 · 5 comments · Fixed by #4996
Closed

If claim search on latter page fails, don't clear out all previous data #4609

tzarebczan opened this issue Jul 30, 2020 · 5 comments · Fixed by #4996
Labels
type: bug Existing functionality is wrong or broken

Comments

@tzarebczan
Copy link
Contributor

See https://lbry.tv/$/discover?t=imherelbry&t=imherelbry&t=imherelbry&t=imherelbry&t=imherelbry&t=imherelbry&content=video

@tzarebczan tzarebczan added the type: bug Existing functionality is wrong or broken label Jul 30, 2020
@tzarebczan
Copy link
Contributor Author

(also not sure why the tag duplicated in URL)

@infinite-persistence
Copy link
Contributor

(also not sure why the tag duplicated in URL)

Covered in 4393

@tzarebczan
Copy link
Contributor Author

@infinite-persistence this still happens, can you take a peek?

@infinite-persistence
Copy link
Contributor

(also not sure why the tag duplicated in URL)

For the tag duplication part, 4393 seems to still be working. Changing [Trending|New|Top] now no longer appends more tags, and also clears out any existing ones.

If claim search on latter page fails, don't clear out all previous data

For this part, I'm not sure what it meant. Is it saying that when changing [Trending|New|Top] and if the query fails, show the Sorry, your request timed out. Modify your options ... message but don't clear out any existing found tiles? But the query has changed, so clearing the tiles should be correct?

@tzarebczan
Copy link
Contributor Author

What happens is that the first page may load, but a subsequent may fail - so instead of clearing out all results, we should show another message that says "can't retrieve more information, try again later". Right now it clears the first page and shows the error too.

Though this is something that will hopefully be fixed with our SDK revamp, so not a huge deal right now unless it's easy to do so.

infinite-persistence added a commit to infinite-persistence/lbry-redux that referenced this issue Nov 6, 2020
…imeout.

## Issue
lbryio/lbry-desktop#4609

## Change
- Don't clear existing results on timeout.
- Mark the "no more results" flag so that the app knows it needs to stop querying.
infinite-persistence added a commit to infinite-persistence/lbry-redux that referenced this issue Nov 8, 2020
…imeout.

## Issue
lbryio/lbry-desktop#4609

## Change
- Don't clear existing results on timeout.
- Add another flag for partial page timeout so that the app can know when to stop querying and display appropriate messages.
infinite-persistence added a commit to infinite-persistence/lbry-redux that referenced this issue Nov 9, 2020
…imeout.

## Issue
lbryio/lbry-desktop#4609

## Change
- Don't clear existing results on timeout.
- Treat this scenario as "last page reached" by marking `claimSearchByQueryLastPageReached`.
neb-b pushed a commit to lbryio/lbry-redux that referenced this issue Nov 13, 2020
…imeout.

## Issue
lbryio/lbry-desktop#4609

## Change
- Don't clear existing results on timeout.
- Treat this scenario as "last page reached" by marking `claimSearchByQueryLastPageReached`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Existing functionality is wrong or broken
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants