New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If claim search on latter page fails, don't clear out all previous data #4609
Comments
(also not sure why the tag duplicated in URL) |
Covered in 4393 |
@infinite-persistence this still happens, can you take a peek? |
For the tag duplication part, 4393 seems to still be working. Changing [Trending|New|Top] now no longer appends more tags, and also clears out any existing ones.
For this part, I'm not sure what it meant. Is it saying that when changing [Trending|New|Top] and if the query fails, show the |
What happens is that the first page may load, but a subsequent may fail - so instead of clearing out all results, we should show another message that says "can't retrieve more information, try again later". Right now it clears the first page and shows the error too. Though this is something that will hopefully be fixed with our SDK revamp, so not a huge deal right now unless it's easy to do so. |
…imeout. ## Issue lbryio/lbry-desktop#4609 ## Change - Don't clear existing results on timeout. - Mark the "no more results" flag so that the app knows it needs to stop querying.
…imeout. ## Issue lbryio/lbry-desktop#4609 ## Change - Don't clear existing results on timeout. - Add another flag for partial page timeout so that the app can know when to stop querying and display appropriate messages.
…imeout. ## Issue lbryio/lbry-desktop#4609 ## Change - Don't clear existing results on timeout. - Treat this scenario as "last page reached" by marking `claimSearchByQueryLastPageReached`.
…imeout. ## Issue lbryio/lbry-desktop#4609 ## Change - Don't clear existing results on timeout. - Treat this scenario as "last page reached" by marking `claimSearchByQueryLastPageReached`.
See https://lbry.tv/$/discover?t=imherelbry&t=imherelbry&t=imherelbry&t=imherelbry&t=imherelbry&t=imherelbry&content=video
The text was updated successfully, but these errors were encountered: