Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add video length and size metadata #597

Closed
wilsonk opened this issue Sep 21, 2017 · 6 comments
Closed

Add video length and size metadata #597

wilsonk opened this issue Sep 21, 2017 · 6 comments
Labels
area: ux area: viewer Tom's Wishlist type: improvement Existing (or partially existing) functionality needs to be changed

Comments

@wilsonk
Copy link

wilsonk commented Sep 21, 2017

The Issue

Consider adding to:
file tiles (at least length?)
file details (both length and size?)

We also have file name, but don't think we need to show that before downloading?

System Configuration

  • LBRY Daemon version:
 "id": null,
  "jsonrpc": "2.0",
  "result": {
    "build": "release",
    "lbrynet_version": "0.15.2",
    "lbryschema_version": "0.0.10",
    "lbryum_version": "3.1.6",
    "os_release": "4.4.0-93-generic",
    "os_system": "Linux",
    "platform": "Linux-4.4.0-93-generic-x86_64-with-Ubuntu-16.04-xenial",
    "processor": "x86_64",
    "python_version": "2.7.12"
  • LBRY App version: 0.15.1
  • LBRY Installation ID:26bru4Kjp3i3VM5KTFVV3ESEkDWEb9CCA2ate4L9XJYTr8PHUK4jPDQqz4JsG73Wfr
  • Operating system: Linux (Linux-4.4.0-93-generic-x86_64-with-Ubuntu-16.04-xenial)

Anything Else

If this information can't be placed on the opening page thumbnails then hopefully it can at least be placed in the video information under the 'published on' information?

@tzarebczan tzarebczan added contributor friendly type: improvement Existing (or partially existing) functionality needs to be changed and removed contributor friendly labels Sep 21, 2017
@tzarebczan
Copy link
Contributor

tzarebczan commented Sep 22, 2017

@wilsonk thanks for the feature suggestion! Check out https://lbry.io/faq/tips

I'll probably have to open up a complimentary issue on the lbry protocol side so that this data is captured during upload. Opened -lbryio/lbry-sdk#918

@KamilPiekutowski
Copy link

I added another element to the table. I am still learning the code, but I added Length section. Not sure how to access the data for the length.

Here is the photo. Let me know if this what you guys had in mind.

screenshot from 2017-09-29 23-26-05

@kauffj
Copy link
Member

kauffj commented Sep 30, 2017

@KamilPiekutowski thanks for your efforts here!

Unfortunately, there's no data to access :/

This will require a much deeper modification to both lbryschema and lbry before this can be supported.

@KamilPiekutowski
Copy link

Is there any app architecture documentation or something that would lead to how lbry,lbry-app and lbryschema are connected?

@btzr-io
Copy link
Collaborator

btzr-io commented Oct 1, 2017

@KamilPiekutowski I hope you found something useful 🙂
API: https://lbryio.github.io/lbry/cli/
APP: https://electron.atom.io/docs/, https://reactjs.org/

@KamilPiekutowski
Copy link

How does hex_encoded_003 get generated in test_data.py?
generate_test_data.py ommits it and makes testing fail.

@alyssaoc alyssaoc added the icebox Long-term storage label Aug 28, 2018
@tzarebczan tzarebczan removed the icebox Long-term storage label Mar 12, 2019
@tzarebczan tzarebczan changed the title Video length tags? Add video length and size metadata Mar 12, 2019
@neb-b neb-b closed this as completed Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ux area: viewer Tom's Wishlist type: improvement Existing (or partially existing) functionality needs to be changed
Projects
None yet
Development

No branches or pull requests

8 participants