Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There is no Windows system notification when the LBC balance changes and LBRY app is minimized in the tray #720

Closed
LavRadis opened this issue Nov 9, 2017 · 3 comments
Closed

There is no Windows system notification when the LBC balance changes and LBRY app is minimized in the tray #720

LavRadis opened this issue Nov 9, 2017 · 3 comments
Labels
help wanted level: 1 No knowledge of the existing code required type: improvement Existing (or partially existing) functionality needs to be changed windows

Comments

@LavRadis
Copy link
Contributor

LavRadis commented Nov 9, 2017

The Issue

When the LBRY app is minimized to tray and LBC wallet balance is changed there is no notification of any kind.
Since this is an important change, there should be some form of notification.

Expected behaviour

If the app is minimized there should be a clear system notification that the wallet balance changed (user received or spent LBC).
It should probably be similar to Win notification when the video has finished downloading.

System Configuration

Win 10
App 0.18.0rc1
Daemon 0.18.0rc1
Installation ID 7tYN144rHXrspzJG9xLP28fi1JztXnbpKro6DBJEQyzBmXTyDgqRLfYsUvHYFVmMe2
@liamcardenas liamcardenas added type: improvement Existing (or partially existing) functionality needs to be changed contributor friendly labels Nov 13, 2017
@liamcardenas liamcardenas added help wanted windows level: 1 No knowledge of the existing code required and removed contributor friendly labels Dec 14, 2017
@dependabot-preview dependabot-preview bot mentioned this issue Apr 2, 2018
Merged
@tzarebczan
Copy link
Contributor

Do you think this should be part of an in-app notification (i.e. #695) or show be a System / OS notification?

@LavRadis
Copy link
Contributor Author

LavRadis commented Aug 6, 2018

I'm not sure. Most wallets show Win system notification when the balance changes.

@alyssaoc
Copy link
Contributor

alyssaoc commented Oct 9, 2018

will consider as part of #695

@alyssaoc alyssaoc closed this as completed Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted level: 1 No knowledge of the existing code required type: improvement Existing (or partially existing) functionality needs to be changed windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@liamcardenas @tzarebczan @LavRadis @alyssaoc