Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In-App notifications. #695

Closed
hackrush01 opened this issue Oct 23, 2017 · 15 comments
Closed

In-App notifications. #695

hackrush01 opened this issue Oct 23, 2017 · 15 comments
Assignees
Labels
area: ux area: viewer consider soon Discuss this issue at the next planning meeting, then remove this label Epic Tom's Wishlist type: discussion A conversation. No specific changes requested type: improvement Existing (or partially existing) functionality needs to be changed type: new feature New functionality that does not exist yet

Comments

@hackrush01
Copy link
Contributor

Inclusion of an in-app notification system would be helpful in many cases such as if we want the people to move from slack to discord, we could just send an in-app notification for the same. It could be extended to other functionalities such as informing about incoming tips, new content, new upload from subscriptions etc.

@liamcardenas liamcardenas added type: improvement Existing (or partially existing) functionality needs to be changed needs: exploration Solution unclear, needs research labels Nov 13, 2017
@tzarebczan tzarebczan added Tom's Wishlist area: ux type: new feature New functionality that does not exist yet area: viewer and removed needs: exploration Solution unclear, needs research labels Jun 29, 2018
@tzarebczan
Copy link
Contributor

tzarebczan commented Jun 29, 2018

Notification scenarios, including the ones mentioned above:

  • Publish completed
  • Download completed
  • Incoming tip
  • Incoming content payment
  • Received LBC
  • New content in subbed channels
  • Trending content
  • Pushed notifications from LBRY about app features / news / content / creators
  • LBRY app updates
  • System outages
  • Vanity URL outbid

@alyssaoc
Copy link
Contributor

@seanyesmunt This should be considered for an epic

@alyssaoc alyssaoc added App "C: type: discussion A conversation. No specific changes requested labels Aug 28, 2018
@alyssaoc alyssaoc added the Epic label Sep 4, 2018
@btzr-io
Copy link
Collaborator

btzr-io commented Sep 9, 2018

WIP (Just the ui, no redux logic yet)

@seanyesmunt any ideas or feedback on this?

notify

@kauffj
Copy link
Member

kauffj commented Sep 9, 2018

Ooooooh I love this. Not Sean but some quick comments from me:

  1. It'd be cool if it showed the number of notifications
  2. I'd keep the design consistent. Keep the spacing allocated for the image/icon the same, as well as the header formatting (unless you just couldn't get this to work...)
  3. Consider adding elements that allow marking notifications as read or to hide them (see how FB manages theirs)
  4. Less stylistic weight could be given to the header

@btzr-io
Copy link
Collaborator

btzr-io commented Sep 10, 2018

notify

Some minor updates, still working on 3

@btzr-io
Copy link
Collaborator

btzr-io commented Sep 10, 2018

colors

@neb-b
Copy link

neb-b commented Sep 10, 2018

This is awesome @btzr-io.

I agree with @kauffj's comments. Maybe add an x in the corner when you hover over one notification to remove it from the stack. For the redux side this should live inlbry-redux. Probably in the notifications reducer.

I think to keep it simple we can just start with adding newly subscribed content and your publish confirmations: "Your file at lbry://something is published" or something similar.

@neb-b
Copy link

neb-b commented Sep 10, 2018

Also this should use theFileTile component to keep it consistent with search/related content.

@btzr-io btzr-io self-assigned this Sep 11, 2018
@btzr-io
Copy link
Collaborator

btzr-io commented Sep 13, 2018

publish confirmations: "Your file at lbry://something is published"

@seanyesmunt There is a modal for that, should I remove it?

@btzr-io
Copy link
Collaborator

btzr-io commented Sep 13, 2018

remove-notify

@neb-b
Copy link

neb-b commented Sep 16, 2018

@btzr-io Sorry I missed your comment.

Maybe we should show the desktop notification if the app is closed, but not if it's open? Will this contain an "in-app" notification when something happens? It would be the same text as the text inside the drop down, but shown right when something happens? Maybe that should be it's own issue.

@btzr-io btzr-io removed their assignment May 30, 2019
@tzarebczan
Copy link
Contributor

Another use case now is comment notifications.

@kauffj kauffj added the consider soon Discuss this issue at the next planning meeting, then remove this label label May 20, 2020
@kauffj
Copy link
Member

kauffj commented May 20, 2020

@seanyesmunt https://github.com/lbryio/internal-apis/pull/1326 will make 6 existing notifications consumable via API and make it much easier to add new ones whenever we want

Expect work to begin on this next week if we can find the time (and we probably should)

@kauffj
Copy link
Member

kauffj commented May 25, 2020

@sean ensure it works as intended

@kauffj
Copy link
Member

kauffj commented Aug 24, 2020

  • Fix spacing
  • Mark individual notification read
  • Unify colors with mobile

@kauffj kauffj closed this as completed Sep 21, 2020
Ruk33 pushed a commit that referenced this issue Feb 25, 2022
Behavior we want:
- hide Advanced Filter for Wild West
- show Advanded Filter & Filter for everything else
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ux area: viewer consider soon Discuss this issue at the next planning meeting, then remove this label Epic Tom's Wishlist type: discussion A conversation. No specific changes requested type: improvement Existing (or partially existing) functionality needs to be changed type: new feature New functionality that does not exist yet
Projects
None yet
Development

No branches or pull requests

7 participants