-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In-App notifications. #695
Comments
Notification scenarios, including the ones mentioned above:
|
@seanyesmunt This should be considered for an epic |
Ooooooh I love this. Not Sean but some quick comments from me:
|
This is awesome @btzr-io. I agree with @kauffj's comments. Maybe add an I think to keep it simple we can just start with adding newly subscribed content and your publish confirmations: |
Also this should use the |
@seanyesmunt There is a modal for that, should I remove it? |
@btzr-io Sorry I missed your comment. Maybe we should show the desktop notification if the app is closed, but not if it's open? Will this contain an "in-app" notification when something happens? It would be the same text as the text inside the drop down, but shown right when something happens? Maybe that should be it's own issue. |
Another use case now is comment notifications. |
@seanyesmunt https://github.com/lbryio/internal-apis/pull/1326 will make 6 existing notifications consumable via API and make it much easier to add new ones whenever we want Expect work to begin on this next week if we can find the time (and we probably should) |
@sean ensure it works as intended |
|
Behavior we want: - hide Advanced Filter for Wild West - show Advanded Filter & Filter for everything else
Inclusion of an in-app notification system would be helpful in many cases such as if we want the people to move from slack to discord, we could just send an in-app notification for the same. It could be extended to other functionalities such as informing about incoming tips, new content, new upload from subscriptions etc.
The text was updated successfully, but these errors were encountered: