Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch resolve fails if single URI encounters an error #842

Closed
jackrobison opened this issue Dec 11, 2017 · 3 comments
Closed

Batch resolve fails if single URI encounters an error #842

jackrobison opened this issue Dec 11, 2017 · 3 comments
Labels
help wanted level: 2 Some knowledge of the existing code is recommended protocol dependent type: bug Existing functionality is wrong or broken

Comments

@jackrobison
Copy link
Member

@tzarebczan commented on Sun Dec 10 2017

The Issue

In a batched resolution, the entire resolve command fails if one of the URLs errors out. This is happening on the homepage at the moment because of an expired claim in the resolve call.

Steps to reproduce

  1. batch a URI resolution with a known bad URL
  2. observe failure

Expected behaviour

Tell us what should happen

Actual behaviour

Tell us what happens instead

System Configuration

  • LBRY Daemon version: 0.18.2
  • LBRY App version: 0.19rc1
  • LBRY Installation ID:
  • Operating system:

Anything Else

Screenshots


@jackrobison commented on Mon Dec 11 2017

resolve in lbrynet handles these cases, this error must be in the app handling of the response.

@liamcardenas liamcardenas added type: bug Existing functionality is wrong or broken help wanted level: 2 Some knowledge of the existing code is recommended labels Dec 14, 2017
@deepalimayekar
Copy link

In the Python file, check the statuscode of the request after the get call. If r.status_code is not 200, skip the response.

@deepalimayekar
Copy link

import requests r = requests.get('fill url) compare r.status_code and if not 200, do not write Thus resolve will not fail if any URL is incorrect.

@lyoshenka
Copy link
Member

closing, as this is a daemon error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted level: 2 Some knowledge of the existing code is recommended protocol dependent type: bug Existing functionality is wrong or broken
Projects
None yet
Development

No branches or pull requests

5 participants