Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "log out" link that clears their auth token #997

Closed
lyoshenka opened this issue Feb 5, 2018 · 4 comments
Closed

Add "log out" link that clears their auth token #997

lyoshenka opened this issue Feb 5, 2018 · 4 comments
Labels
area: ux help wanted level: 2 Some knowledge of the existing code is recommended needs: exploration Solution unclear, needs research Tom's Wishlist type: improvement Existing (or partially existing) functionality needs to be changed type: new feature New functionality that does not exist yet

Comments

@lyoshenka
Copy link
Member

No description provided.

@tzarebczan
Copy link
Contributor

I assume this is the temporary workaround to #926 ?

How would this work? Would it reload the app and clear out local storage (so they are prompted for email on next refresh)?

@tzarebczan tzarebczan added type: improvement Existing (or partially existing) functionality needs to be changed area: ux needs: exploration Solution unclear, needs research help wanted level: 2 Some knowledge of the existing code is recommended type: new feature New functionality that does not exist yet labels Apr 18, 2018
@tzarebczan tzarebczan mentioned this issue May 18, 2018
Closed
@tzarebczan tzarebczan mentioned this issue Jun 8, 2018
Merged
@daovist daovist self-assigned this Jul 23, 2018
@alyssaoc alyssaoc added this to the Aug 6th (Desktop) milestone Jul 23, 2018
@alyssaoc alyssaoc removed this from the Aug 6th (Desktop) milestone Aug 20, 2018
@alyssaoc alyssaoc added the needs: grooming Issue needs to be groomed before work can start label Sep 12, 2018
@alyssaoc alyssaoc removed the needs: grooming Issue needs to be groomed before work can start label Oct 4, 2018
@alyssaoc
Copy link
Contributor

alyssaoc commented Oct 4, 2018

@daovist Can this issue be closed, all related issues have been merged and closed.

@tzarebczan
Copy link
Contributor

This is still a valid issue. If a user mistypes their email, there's no way to clear it out.

@tzarebczan
Copy link
Contributor

We added a change email link with instructions on how to clear the token. There's another issue filed for removing the need for a token and to use a cookie instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: ux help wanted level: 2 Some knowledge of the existing code is recommended needs: exploration Solution unclear, needs research Tom's Wishlist type: improvement Existing (or partially existing) functionality needs to be changed type: new feature New functionality that does not exist yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@lyoshenka @liamcardenas @tzarebczan @alyssaoc @daovist @lbry-bot