New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade daemon to 0.19.0 #1032

Merged
merged 15 commits into from Mar 9, 2018

Conversation

Projects
None yet
3 participants
@liamcardenas
Contributor

liamcardenas commented Feb 21, 2018

No description provided.

liamcardenas added some commits Feb 21, 2018

@tzarebczan

This comment has been minimized.

Show comment
Hide comment
@tzarebczan

tzarebczan Feb 26, 2018

Member

@liamcardenas adding my comments from Slack:

  1. my channels are showing up in Published area, they shouldn't be.

  2. Clicking on items in Downloads/Published area go to an "undefined" claim name, but has correct claim_id

  3. clicking on claims from the transaction screen also goes to undefined claims as #2

Still waiting to hear back from Jack about some file_list changes, but it may be worth looking at lbryio/lbry#1127 to see how it currently works. My main concern will be the editing of already edited claims - I think we use the file_list outpoint when trying to edit, which may not be up to date on the file_list side but should be on claim_list_mine.

Member

tzarebczan commented Feb 26, 2018

@liamcardenas adding my comments from Slack:

  1. my channels are showing up in Published area, they shouldn't be.

  2. Clicking on items in Downloads/Published area go to an "undefined" claim name, but has correct claim_id

  3. clicking on claims from the transaction screen also goes to undefined claims as #2

Still waiting to hear back from Jack about some file_list changes, but it may be worth looking at lbryio/lbry#1127 to see how it currently works. My main concern will be the editing of already edited claims - I think we use the file_list outpoint when trying to edit, which may not be up to date on the file_list side but should be on claim_list_mine.

@lbryio lbryio deleted a comment from codacy-bot Mar 9, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 9, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 9, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 9, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 9, 2018

liamcardenas

@lbryio lbryio deleted a comment from codacy-bot Mar 9, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 9, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 9, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 9, 2018

@liamcardenas liamcardenas changed the title from Upgrade daemon to 0.19.0rc35 [Don't merge] to Upgrade daemon to 0.19.0 Mar 9, 2018

liamcardenas

@lbryio lbryio deleted a comment from codacy-bot Mar 9, 2018

@codacy-bot

This comment has been minimized.

Show comment
Hide comment
@codacy-bot

codacy-bot Mar 9, 2018

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1
- Added 1
           

See the complete overview on Codacy

codacy-bot commented Mar 9, 2018

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1
- Added 1
           

See the complete overview on Codacy

@lbryio lbryio deleted a comment from codacy-bot Mar 9, 2018

@lbryio lbryio deleted a comment from codacy-bot Mar 9, 2018

const height2 = fileInfo2.height;
dateNew: fileInfos =>
fileInfos.slice().sort((fileInfo1, fileInfo2) => {
const height1 = this.props.claimsById[fileInfo1.claim_id]

This comment has been minimized.

@liamcardenas liamcardenas merged commit 4e14c89 into master Mar 9, 2018

3 of 5 checks passed

Codacy/PR Quality Review Not so good... This pull request quality could be better.
Details
OSX (LBRY App) TeamCity build started
Details
Linux (LBRY App) TeamCity build finished
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@lyoshenka lyoshenka deleted the daemon19 branch Mar 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment