New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share speech URLs on File and Channel pages #1222

Merged
merged 2 commits into from May 30, 2018

Conversation

Projects
None yet
4 participants
@daovist
Collaborator

daovist commented Mar 30, 2018

New PR for #1028 @tzarebczan @liamcardenas

This creates <ViewOnWebButton> with a GLOBE icon and uses it on <FilePage> and <ChannelPage>

Also fixes ~10 eslint errors

@liamcardenas

Tested and looks good.

Show outdated Hide outdated CHANGELOG.md
Show outdated Hide outdated src/renderer/component/common/form-components/form-row.jsx
@@ -180,6 +183,14 @@ class FilePage extends React.Component<Props> {
<SubscribeButton uri={subscriptionUri} channelName={channelName} />
</React.Fragment>
)}
{speechSharable && (

This comment has been minimized.

@liamcardenas

liamcardenas Mar 30, 2018

Contributor

have you run yarn format?

@liamcardenas

liamcardenas Mar 30, 2018

Contributor

have you run yarn format?

This comment has been minimized.

@daovist

daovist Mar 30, 2018

Collaborator

I did, and it did not change anything

@daovist

daovist Mar 30, 2018

Collaborator

I did, and it did not change anything

Show outdated Hide outdated src/renderer/page/file/view.jsx
@liamcardenas

I meant to request changes

@daovist

This comment has been minimized.

Show comment
Hide comment
@daovist

daovist Mar 30, 2018

Collaborator

I am not sure what's going on with this conflict in src/renderer/scss/component/_form-field.scss

What Github tells me is a problem on lines 54-58 is not a problem locally

Collaborator

daovist commented Mar 30, 2018

I am not sure what's going on with this conflict in src/renderer/scss/component/_form-field.scss

What Github tells me is a problem on lines 54-58 is not a problem locally

@tzarebczan tzarebczan requested a review from liamcardenas Apr 3, 2018

@lbry-bot lbry-bot assigned liamcardenas and unassigned liamcardenas Apr 3, 2018

@tzarebczan tzarebczan requested review from seanyesmunt and removed request for liamcardenas May 10, 2018

@seanyesmunt

This comment has been minimized.

Show comment
Hide comment
@seanyesmunt

seanyesmunt May 11, 2018

Member

Can you rebase and get this up to date?

Member

seanyesmunt commented May 11, 2018

Can you rebase and get this up to date?

@tzarebczan

This comment has been minimized.

Show comment
Hide comment
@tzarebczan

tzarebczan May 29, 2018

Member

@seanyesmunt Tired of adding buttons to the show page yet? haha Wonder how this fits in with your changes to file actions. I'll try to give it a whirl today.

Member

tzarebczan commented May 29, 2018

@seanyesmunt Tired of adding buttons to the show page yet? haha Wonder how this fits in with your changes to file actions. I'll try to give it a whirl today.

@seanyesmunt

This is awesome. I think the button placement is fine.

@seanyesmunt seanyesmunt merged commit 06956ec into lbryio:master May 30, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment