Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share speech URLs on File and Channel pages #1222

Merged
merged 2 commits into from May 30, 2018

Conversation

Projects
None yet
4 participants
@daovist
Copy link
Contributor

commented Mar 30, 2018

New PR for #1028 @tzarebczan @liamcardenas

This creates <ViewOnWebButton> with a GLOBE icon and uses it on <FilePage> and <ChannelPage>

Also fixes ~10 eslint errors

@liamcardenas
Copy link
Contributor

left a comment

Tested and looks good.

@@ -16,6 +16,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/).
* App category for Linux ([#877](https://github.com/lbryio/lbry-app/pull/877))
* Add YouTube Sync reward ([#1147](https://github.com/lbryio/lbry-app/pull/1147))
* Retain previous screen sizing on startup ([#338](https://github.com/lbryio/lbry-app/issues/338))
* Add 'Go to page' input on channel pagination ([#1166](https://github.com/lbryio/lbry-app/pull/1166))

This comment has been minimized.

Copy link
@liamcardenas

liamcardenas Mar 30, 2018

Contributor

you request seems to be intertwined with another one somehow. Can you please figure out how to take out these pagination related changes?

@@ -4,6 +4,7 @@ import * as React from 'react';
import classnames from 'classnames';

type Props = {
centered?: boolean,

This comment has been minimized.

Copy link
@liamcardenas

liamcardenas Mar 30, 2018

Contributor

I assume this is from the pagination PR?

@@ -180,6 +183,14 @@ class FilePage extends React.Component<Props> {
<SubscribeButton uri={subscriptionUri} channelName={channelName} />
</React.Fragment>
)}
{speechSharable && (

This comment has been minimized.

Copy link
@liamcardenas

liamcardenas Mar 30, 2018

Contributor

have you run yarn format?

This comment has been minimized.

Copy link
@daovist

daovist Mar 30, 2018

Author Contributor

I did, and it did not change anything

@@ -123,6 +123,9 @@ class FilePage extends React.Component<Props> {
if (channelName && channelClaimId) {
subscriptionUri = buildURI({ channelName, claimId: channelClaimId }, false);
}
const free = costInfo && costInfo.cost === 0;

This comment has been minimized.

Copy link
@liamcardenas

liamcardenas Mar 30, 2018

Contributor

does free need to be its own variable?

@liamcardenas
Copy link
Contributor

left a comment

I meant to request changes

@daovist

This comment has been minimized.

Copy link
Contributor Author

commented Mar 30, 2018

I am not sure what's going on with this conflict in src/renderer/scss/component/_form-field.scss

What Github tells me is a problem on lines 54-58 is not a problem locally

@tzarebczan tzarebczan requested a review from liamcardenas Apr 3, 2018

@lbry-bot lbry-bot assigned liamcardenas and unassigned liamcardenas Apr 3, 2018

@tzarebczan tzarebczan requested review from seanyesmunt and removed request for liamcardenas May 10, 2018

@seanyesmunt

This comment has been minimized.

Copy link
Member

commented May 11, 2018

Can you rebase and get this up to date?

@daovist daovist force-pushed the daovist:share-speech-urls branch from 30b5f95 to d2a5d21 May 23, 2018

@daovist daovist force-pushed the daovist:share-speech-urls branch from d2a5d21 to c6732d3 May 25, 2018

@tzarebczan

This comment has been minimized.

Copy link
Member

commented May 29, 2018

@seanyesmunt Tired of adding buttons to the show page yet? haha Wonder how this fits in with your changes to file actions. I'll try to give it a whirl today.

@seanyesmunt
Copy link
Member

left a comment

This is awesome. I think the button placement is fine.

@seanyesmunt seanyesmunt merged commit 06956ec into lbryio:master May 30, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.