Select thumbnail, spee.ch upload #1248
Conversation
|
@liamcardenas this is ready for review. I think I got the rebase right but I'm not positive. I tested it post merge, commit, push, and it works fine. A couple things that could/maybe should be done: The modal and publish form write to the same Should we disable publishing until the upload is complete? Until it does, the thumbnail field is a blank string, it doesn't get back the url with a claim_id until the upload is complete. |
daovist
force-pushed
the
select-thumbnail
branch
2 times, most recently
from
ee8b1c4
to
8fea5ec
Compare
|
@seanyesmunt this is working and ready for review |
| const { type, currentPath, fileLabel, directoryLabel } = this.props; | ||
|
|
||
| const label = | ||
| type === 'file' ? fileLabel || __('Choose File') : directoryLabel || __('Choose Directory'); |
There was a problem hiding this comment.
Can you add parens for legibility?
| @@ -73,6 +77,10 @@ class PublishForm extends React.PureComponent<Props> { | |||
| (this: any).getNewUri = this.getNewUri.bind(this); | |||
| } | |||
|
|
|||
| componentWillMount() { | |||
There was a problem hiding this comment.
This method is being deprecated, it's good to start using getDerivedStateFromProps()
https://reactjs.org/docs/react-component.html#static-getderivedstatefromprops
| const makeid = () => { | ||
| let text = ''; | ||
| const possible = 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789'; | ||
| for (let i = 0; i < 24; i += 1) text += possible.charAt(Math.floor(Math.random() * 62)); |
There was a problem hiding this comment.
Can you split this line out with brackets for legibility?
| const data = new FormData(); | ||
| const name = makeid(); | ||
| const blob = new Blob([thumbnail], { type: `image/${fileExt.slice(1)}` }); | ||
| data.append('name', name); |
There was a problem hiding this comment.
Can you clean up some of the formatting from ln90 to 110?
Line breaks, indentation, etc
|
I cleaned this up based on comments from @skhameneh and other changes since the last time I worked on I did not implement getDerivedStateFromProps thinking that pattern is all over the app and should be its own issue to clean up everywhere. It now resets the thumbnail upload status when the whole form is reset. I refactored the errors and tested it on a faulty URL and everything worked like it should. Though some more @tzarebczan testing is probably in order. |
| export const SEND_TIP = 'send_tip'; | ||
| export const PUBLISH = 'publish'; | ||
| export const SEARCH = 'search'; | ||
| export const CONFIRM_THUMBNAIL_UPLOAD = 'confirmThumbnailUpload'; |
| @@ -30,6 +36,85 @@ export const doUpdatePublishForm = (publishFormValue: UpdatePublishFormData) => | |||
| data: { ...publishFormValue }, | |||
| }); | |||
|
|
|||
| export const doResetThumbnailStatus = () => (dispatch: Dispatch): Action => | |||
| fetch('https://spee.ch/api/channel/availability/@testing') | |||
…atus on componentWillMount
…atus on componentWillMount
This PR...
Lets
<FileSelector>take custom labelsAdds
thumbnail_upload_statusesconstantsAdds
<SelectThumbnail>component and uses it in<PublishForm>Adds
ModalConfirmThumbnailUploadwhich is called by<SelectThumbnail>Adds
uploadThumbnailStatustoPublishState(and notPublishParams) inpublishReducerUses existing reducers and selectors, adds
doResetThumbnailStatusanddoUploadThumbnailactions for spee.ch requestsAdds
a.linkCSSCleans up some errors I got committing changes