Support channel definitions from /file/list_homepage #1267
Conversation
src/renderer/page/discover/view.jsx
Outdated
| key={category} | ||
| category={category.split('#')[0]} | ||
| categoryLink={category} | ||
| names={[]} |
There was a problem hiding this comment.
This prop should just have a default value of []
| @@ -1,7 +1,7 @@ | |||
| // @flow | |||
| import React from 'react'; | |||
| import Page from 'component/page'; | |||
| import CategoryList from 'component/common/category-list'; | |||
| import CategoryList from 'component/categoryList'; | |||
There was a problem hiding this comment.
These changes aren't needed anymore since subscriptions page isn't using this component
| const { canScrollNext, canScrollPrevious } = this.state; | ||
| const channel = |
There was a problem hiding this comment.
A better name for this is probably channelURIs
| const { canScrollNext, canScrollPrevious } = this.state; | ||
| const channel = |
There was a problem hiding this comment.
you should also be able to use makeSelectClaimsInChannelForCurrentPage, which is what the channel page uses. Just get the first page of content and you won't have to worry about this logic.
There was a problem hiding this comment.
I have tried using in the makeSelectClaimsInChannelForCurrentPage selector in place of the other two and the logic that goes with them, and I keep running into problems. I'm passing props.categoryLink as the uri, which I think should be fine based on console logging props. I have tried various forms of the makeSelect pattern I found in the RewardLink container-component to no avail, including rewriting the selectors, but there are so many not-working version I'm not sure what to push/show you.
| @@ -109,6 +117,9 @@ class CategoryList extends React.PureComponent<Props, State> { | |||
|
|
|||
| // check if a card is fully visible horizontally | |||
| isCardVisible = (section: HTMLElement) => { | |||
| if (!section) { | |||
| @@ -32,6 +35,11 @@ class CategoryList extends React.PureComponent<Props, State> { | |||
| } | |||
|
|
|||
| componentDidMount() { | |||
| const { category, fetchChannel } = this.props; | |||
| if (category[0] === '@') { | |||
| fetchChannel(category); | |||
There was a problem hiding this comment.
Use makeSelectFetchingChannelClaims to make sure we aren't already fetching for this channel.
|
|
||
| type Props = { | ||
| category: string, | ||
| names: Array<string>, | ||
| categoryLink?: string, | ||
| claimsByChannel: {}, | ||
| claimsById: {}, |
There was a problem hiding this comment.
You can use the Caim type that I recently created.
|
This PR still contains sample data to demonstrate the functionality. I will remove it and clean up commit history following approval. |
|
Lets merge this. @daovist once you remove the mock data I'll merge |
daovist
force-pushed
the
explore-channels
branch
2 times, most recently
from
f576330
to
4f7a647
Compare
This PR for issue #1049
Is ready to be reviewed by @liamcardenas
Uses existing reducers, actions, selectors
Moves
component/common/category-list.jsxto its own top level component atcomponent/categoryListbecause it needs props tofetchChanneland selectclaimsByChannelandclaimsByIdFetches channels in
componentDidMountwhen the category is a channelReturns false in
isCardVisiblewhen!section-- this fixed the error I was getting; I'm not sure exactly how the code for the UI worksAdds const
channelto theCategoryListrenderfunction, which is an empty array until the data comes in, and once the data comes in is an array of proper uris made with 'buildURIfromcategory` selector dataMaps the
channelarray to<FileCard>components when appropriateDisplays a '
for a channel (categoryLink,names=[]) whenfeaturedUris[category].lengthis false inDiscoverPage`Imports
CategoryListfrom new location in Discover and Subscriptions pagesFixes various linting errors I found along the way
Includes fake data for demo/testing purposes to be removed after review/updates