First run changes for invite page #2221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neb-b
force-pushed
the
invite
branch
2 times, most recently
from
1fb0214
to
5e118e0
Compare
neb-b
commented
Jan 24, 2019
| @@ -19,6 +19,7 @@ const defaultState = { | |||
| showUnavailable: getLocalStorageSetting(SETTINGS.SHOW_UNAVAILABLE, true), | |||
| welcome_acknowledged: getLocalStorageSetting(SETTINGS.NEW_USER_ACKNOWLEDGED, false), | |||
| email_collection_acknowledged: getLocalStorageSetting(SETTINGS.EMAIL_COLLECTION_ACKNOWLEDGED), | |||
| invite_acknowledged: getLocalStorageSetting(SETTINGS.INVITE_ACKNOWLEDGED, false), | |||
There was a problem hiding this comment.
All of these first run "settings" probably shouldn't live here. Not sure how tricky it would be to migrate them just to regular values saved by redux-persist. Then we can get rid of getLocalStorageSetting.
Works fine for now though, but something to keep in mind.
added 4 commits
January 26, 2019 18:50
neb-b
changed the title
skhameneh
approved these changes
Jan 28, 2019
| label: 'Overview', | ||
| path: '/wallet', | ||
| active: currentPage === 'wallet', | ||
| ...buildLink('Overview', PAGES.WALLET), |
There was a problem hiding this comment.
Could make an array of these pairs and do a map.
There was a problem hiding this comment.
Eh I think I'll leave it. Some of the links are slightly different, and then I would need to change all of those into objects, so there will still be some repetition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Notes