Fixed error message to include numbers #2336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch @eggplantbren! Since this is the same code in two places, Would you be able to combine them so we aren't duplicating this? If not we can just merge it as is. |
|
I don't know whatever language this is, so I'm not really capable of that. Feel free to do it if it's trivial though. |
|
No problem. I'll push up a commit to your branch then merge this. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check all that apply to this PR using "x":
PR Type
What kind of change does this PR introduce?
Fixes
Just noticed that an error message was slightly incorrect (AFAIK lbry URLs can use numbers) so I fixed that.
Issue Number:
What is the current behavior?
Numbers weren't mentioned.
What is the new behavior?
Numbers are mentioned.