Channel edit4 #2584
Merged
Channel edit4 #2584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neb-b
suggested changes
Jul 1, 2019
| const possible = 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789'; | ||
| for (let i = 0; i < 24; i += 1) text += possible.charAt(Math.floor(Math.random() * 62)); | ||
| return text; | ||
| }; |
There was a problem hiding this comment.
We already use the uuid module, lets just use that here.
There was a problem hiding this comment.
flow doesn't like import {v4 as uuidv4} from uuid;
src/ui/page/channel/view.jsx
Outdated
| } else if (bid <= MINIMUM_PUBLISH_BID) { | ||
| setBidError(__('Your deposit must be higher')); | ||
| } | ||
| }; |
There was a problem hiding this comment.
We use this same logic in the publish form. Lets pull it into it's own function.
It can accept bid, balance, amount and return an error if it's bad. If there is no error, update the form, if there is an error, setError
const error = checkBidStuff(amount, balance, bid)
if (error) {
setBidError(error)
} else {
setParams()
}
There was a problem hiding this comment.
DIdn't do this yet.
I'm thinking checkBidStuff(amount, balance, bid, errorFn, updateFn) would be the signature? Or do I misunderstand you?
updates work asset upload works channelForm component
|
This has been updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature:
Channel page updates
Re: #561
Should be broken out of the channel page - probably requires useContext wrapper.
Not happy with upload function living in component.
Still a bug with updating and status messaging on submit.
Mostly unstyled.