Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add provision for adding multiple tags by using commas #2833

Closed
toktoakhil opened this issue Sep 1, 2019 · 22 comments
Closed

Add provision for adding multiple tags by using commas #2833

toktoakhil opened this issue Sep 1, 2019 · 22 comments
Assignees
Labels
area: creator hacktoberfest Welcome to Hacktoberfest help wanted type: new feature New functionality that does not exist yet

Comments

@toktoakhil
Copy link

Is your feature request related to a problem? Please describe.
There is no option for adding multiple tags at once

Describe the solution you'd like
Add option for adding multiple tags using comma separated
Capture
option

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@toktoakhil toktoakhil added the type: new feature New functionality that does not exist yet label Sep 1, 2019
@tzarebczan
Copy link
Contributor

I like the suggestion, thanks @toktoakhil !!!

@toktoakhil
Copy link
Author

My pleasure

@neb-b neb-b added hacktoberfest Welcome to Hacktoberfest help wanted labels Sep 30, 2019
@pranabs1ngh
Copy link
Contributor

Hey, can this issue be assigned to me ?

@tzarebczan
Copy link
Contributor

She's all yours! Thanks for taking a stab at it

@pranabs1ngh
Copy link
Contributor

pranabs1ngh commented Oct 8, 2019

hey, is there a repo map to check, where all the components are used? If not, I only want to know, exactly where is the TagSelect (the tag entering component) used.

@neb-b
Copy link

neb-b commented Oct 8, 2019

Not really. You can just search for it though
https://github.com/lbryio/lbry-desktop/search?q=%3CTagsSelect&unscoped_q=%3CTagsSelect

This has made me realize we are inconsistent with our naming. If you are up to it, could you also change these to use the same name?

@pranabs1ngh
Copy link
Contributor

Okay, I will change them !!

@pranabs1ngh
Copy link
Contributor

Everything done. I'm trying to commit the changes to a new branch, its showing some error:

husky > pre-commit hook failed (add --no-verify to bypass)

Should I commit, without verifying?

@neb-b
Copy link

neb-b commented Oct 8, 2019

That means there are Flow errors or lint errors. There should be some explanation of the error(s) if you scroll up in your terminal.

@pranabs1ngh
Copy link
Contributor

[2019-10-09 01:53:48.372] Building package heap
[2019-10-09 01:53:48.517] Loading libraries
[2019-10-09 01:53:51.361] Resolving dependencies
[2019-10-09 01:54:11.380] Failed to load recheck stats from "C:\Users\pks\AppData\Local\Temp\flow\CzCzBUserszBpkszBDocumentszBHacktoberzBlbry-desktop.recheck_stats". Reason: "File doesn't exist"
[2019-10-09 01:54:11.654] to_merge: Focused: 4, Dependents: 0, Dependencies: 6
[2019-10-09 01:54:11.654] unchanged_checked: Focused: 0, Dependents: 0, Dependencies: 0
[2019-10-09 01:54:11.654] Calculating dependencies
[2019-10-09 01:54:11.654] Merging
[2019-10-09 01:54:12.657] Merge skipped 0 of 10 modules
[2019-10-09 01:54:12.663] Done
[2019-10-09 01:54:12.663] Checked set: Focused: 4, Dependents: 0, Dependencies: 6

husky > pre-commit hook failed (add --no-verify to bypass)

@pranabs1ngh
Copy link
Contributor

Its showing, that the recheck stats doesn't exist, is it that, or I missed something?

@neb-b
Copy link

neb-b commented Oct 8, 2019

Is there anything above that message?

Maybe try running yarn before commiting?

@pranabs1ngh

This comment has been minimized.

@neb-b
Copy link

neb-b commented Oct 8, 2019

Hm, I'm not sure what this is. You can just use --no-verify and i'll check it out on my computer

@pranabs1ngh
Copy link
Contributor

pranabs1ngh commented Oct 8, 2019

On Windows, paths must be less than 248 characters for directories and 260 characters for files. This path has 277 characters. Skipping C:\Users\pks\Documents\Hacktober\lbry-desktop

This message is repeating itself for multiple core-js dependency's files.

Its repeated in the above comment too.

@neb-b
Copy link

neb-b commented Oct 8, 2019

@tzarebczan Have you seen anything like that on windows?

@pranabs1ngh
Copy link
Contributor

@tzarebczan Have you seen anything like that on windows?

Not sure.

@pranabs1ngh
Copy link
Contributor

I think its some error on my PC. I'm commiting this. You verify it before merging.

Is this okay?

@neb-b
Copy link

neb-b commented Oct 8, 2019

yes

@neb-b neb-b closed this as completed Oct 10, 2019
@toktoakhil
Copy link
Author

toktoakhil commented Apr 12, 2020

My Mistake Still on android , desktop and lbry.tv coma separation for adding multiple tags is not working..... FYI

@tzarebczan
Copy link
Contributor

tzarebczan commented Apr 12, 2020

Just type the tags comma seperated and click enter or the plus next to the suggested input.

@toktoakhil
Copy link
Author

Just type the tags comma seperated and click enter or the plus next to the suggested input.

Sorry my mistake.... Just confirmed.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: creator hacktoberfest Welcome to Hacktoberfest help wanted type: new feature New functionality that does not exist yet
Projects
None yet
Development

No branches or pull requests

4 participants