Onboarding + youtube transfer + channels page #2925

neb-b · 2019-09-26T16:17:05Z

Cleanup from the initial MVP

Before you review

A ton of changes in this PR are from moving blocks to use the new <Card /> component. You can skip page/settings/view.jsx and page/help/view.jsx since I just moved stuff around.

Changes

Adds channel page with youtube sync status component
- Add link from the channel page to this so youtubers who just search for their channel in the search bar can easily get to the channels page
moves all effects out of util/ and into effects/
moves a lot of cards over to the new Card component
- Removed a decent amount of .cardxx styles
- Also made some progress removing .card--xxx references on non-card elements to use the more generic .section--xx classes

neb-b · 2019-09-27T18:23:48Z

src/ui/component/syncPassword/view.jsx

+  return (
+    <Form onSubmit={handleSubmit}>
+      <Card
+        title={__('Enter Your LBRY Password')}


Probably could use some help text here? This is when you are logging in to an account that was encrypted with a password. You need to use the password you used on the previous device

"Wallet Password [?]"

[?]: Your wallet password was set when you previously installed LBRY on another device.

where [?] = mouseoverable help thing

Does it have to be another device though? Is wallet password put into OS keyring? If not, couldn't it be the same machine/install?

Good point, it could be saved from an old install on the same device.

Let's just say the following, it's nice and ambiguous:

[?]: You set your wallet password when you previously installed LBRY.

neb-b · 2019-09-27T18:45:33Z

src/ui/component/userEmailNew/view.jsx

+          name="sync_checkbox"
+          label={__('Sync your balance between devices')}
+          helper={
+            balance > 0 ? __('This is only available for empty wallets') : __('Maybe some more text about something')


why is it only available for empty wallets?

That is a current restriction of the sync API, though I don't think it will be like that for long.

kauffj

mostly requested copy, did not look at most of PR

src/ui/component/userEmailNew/view.jsx

tzarebczan · 2019-09-28T17:57:20Z

dark mode inputs need to be fixed - see tag selection/settings page
prompt for sync after signing in - this way we can compare local to remote hashes, and support existing balances if the hashes match or if no wallet has been synced before (many existing users).
support youtube scenario where channel is not synced and claim id won't resolve. This will happen if someone opens the app but isn't synced up yet, or if their channel was never synced for some reason. We'd want to show the status (pending/queued/abandoned) here and maybe a link to the sync page.
if someone has a completed channel transfer, we won't show any pending ones (we do a .some on completed)

nice to have:

driver from channel page to claim channel
delete button on channel page (help those with duplicate/multiple channels clean up after sync)
at least show lbc locked in tips ...this will really help with youtubers being confused about their balance

bugs:

publish page shows "You are currently editing a claim." even if you aren't (cleared state)
scroll to top bugs

tzarebczan · 2019-09-30T13:20:54Z

another small thing - a channel pending confirmation refreshes repeated on channels page. We may eventually have to do something similar to pending publishes.

kauffj

Generally looks good.

kauffj · 2019-09-30T21:14:19Z

src/ui/component/claimPreview/view.jsx

@@ -219,7 +232,7 @@ const ClaimPreview = forwardRef<any, {}>((props: Props, ref: any) => {
              </div>
            )}
          </div>
-          <ClaimTags uri={uri} type={type} />
+          {properties !== undefined ? properties : <ClaimTags uri={uri} type={type} />}


What should properties be when you want the positive action to happen? I suspect this check should be stronger

Mainly properties={false} to hide them.

src/ui/component/publishFile/view.jsx

src/ui/component/publishPrice/view.jsx

kauffj · 2019-09-30T21:25:15Z

src/ui/component/splash/view.jsx

      this.setState({
        message: __('Blockchain Sync'),
-        details: `${__('Catching up...')} (${__(format, wallet.blocks_behind)})`,
+        details: `${__('Catching up...')} (${__(amountBehind, { amountBehind: wallet.blocks_behind })})`,


This should just be __( now, not ${__(, right?

(Also, this is where __n could be useful if we want it)

We still need the $ because it's wrapped in a template string

kauffj · 2019-09-30T21:32:15Z

src/ui/component/userSignIn/view.jsx

+  const hasYoutubeChannels = youtubeChannels && Boolean(youtubeChannels.length);
+  const hasTransferrableYoutubeChannels = hasYoutubeChannels && youtubeChannels.some(channel => channel.transferable);
+  const hasPendingYoutubeTransfer =
+    hasYoutubeChannels && youtubeChannels.some(channel => channel.transfer_state === 'pending_transfer');


'pending_transfer' should probably be a lbryio constant :/

src/ui/component/youtubeTransferWelcome/view.jsx

kauffj · 2019-09-30T21:50:00Z

src/ui/page/channels/view.jsx

+      ) : (
+        <section className="main--empty">
+          <div className=" section--small">
+            <h2 className="section__title--large">{__('No Channels Created Yet')}</h2>


stylistically I think empty states could still use work

because the state is empty, anything being displayed already has a lot of emphasis

this empty state (and some others) use large bold text, I think this could be softened/reduced

I also think more horizontal space could be used before wrapping

Maybe look at https://material.io/design/communication/empty-states.html for how Material Design does it

src/ui/page/discover/view.jsx

src/ui/page/help/view.jsx

lbry-bot assigned neb-b Sep 26, 2019

neb-b force-pushed the onboarding-desktop branch 2 times, most recently from b724046 to 106baa9 Compare September 26, 2019 19:41

lbry-bot unassigned neb-b Sep 27, 2019

neb-b commented Sep 27, 2019

View reviewed changes

lbry-bot assigned neb-b Sep 27, 2019

neb-b commented Sep 27, 2019

View reviewed changes

lbry-bot assigned neb-b and unassigned neb-b Sep 27, 2019

neb-b force-pushed the onboarding-desktop branch 2 times, most recently from af6f155 to cb0387c Compare September 27, 2019 18:57

lbry-bot assigned neb-b and unassigned neb-b Sep 27, 2019

kauffj reviewed Sep 27, 2019

View reviewed changes

lbry-bot assigned neb-b and unassigned neb-b Sep 27, 2019

neb-b changed the title ~~[wip] Onboarding + youtube transfer + channels page~~ Onboarding + youtube transfer + channels page Sep 30, 2019

kauffj self-requested a review September 30, 2019 19:02

lbry-bot assigned kauffj and unassigned neb-b Sep 30, 2019

neb-b force-pushed the onboarding-desktop branch from 6db47e7 to f63d728 Compare September 30, 2019 19:53

kauffj requested changes Sep 30, 2019

View reviewed changes

lbry-bot assigned neb-b and unassigned kauffj and neb-b Sep 30, 2019

lbry-bot assigned neb-b and unassigned neb-b Oct 1, 2019

neb-b force-pushed the onboarding-desktop branch 2 times, most recently from 6d62207 to 064b47e Compare October 1, 2019 05:04

Sean Yesmunt added 8 commits October 1, 2019 01:20

onboarding + youtube transfer + channel page

0ae4580

cleanup

e4070cb

CARD ALL THE THINGS

19c536b

more cleanup

d60a6ce

pr feedback

8bd17ba

fix scroll restoration

9d4d6f9

fix settings on lbry.tv

870e83c

v0.36.0-rc.1

c1f25e5

neb-b force-pushed the onboarding-desktop branch from f690545 to c1f25e5 Compare October 1, 2019 05:21

neb-b merged commit 30a9aac into master Oct 1, 2019

neb-b deleted the onboarding-desktop branch October 15, 2019 19:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Onboarding + youtube transfer + channels page #2925

Onboarding + youtube transfer + channels page #2925

neb-b commented Sep 26, 2019 •

edited

Loading

neb-b Sep 27, 2019

kauffj Sep 27, 2019

neb-b Sep 27, 2019

kauffj Sep 27, 2019

neb-b Sep 27, 2019

kauffj Sep 27, 2019

neb-b Sep 27, 2019

kauffj left a comment

tzarebczan commented Sep 28, 2019 •

edited

Loading

tzarebczan commented Sep 30, 2019

kauffj left a comment

kauffj Sep 30, 2019

neb-b Oct 1, 2019

kauffj Sep 30, 2019

neb-b Oct 1, 2019

kauffj Sep 30, 2019

kauffj Sep 30, 2019

Onboarding + youtube transfer + channels page #2925

Onboarding + youtube transfer + channels page #2925

Conversation

neb-b commented Sep 26, 2019 • edited Loading

Before you review

Changes

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kauffj left a comment

Choose a reason for hiding this comment

tzarebczan commented Sep 28, 2019 • edited Loading

tzarebczan commented Sep 30, 2019

kauffj left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

neb-b commented Sep 26, 2019 •

edited

Loading

tzarebczan commented Sep 28, 2019 •

edited

Loading