Add char count and max char info near textarea of comments area #2944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neb-b
suggested changes
Sep 30, 2019
src/ui/scss/component/_comments.scss
Outdated
|
|
||
| .comment__char-count { | ||
| align-self: flex-end; | ||
| font-size: 12px; |
There was a problem hiding this comment.
Can you change this to font-size: var(--font-label);
| @@ -141,10 +146,15 @@ export class FormField extends React.PureComponent<Props> { | |||
| </div> | |||
| ); | |||
| } else if (type === 'textarea') { | |||
| const hasCharCount = charCount !== undefined && charCount >= 0; | |||
| const countInfo = hasCharCount && ( | |||
| <span className="comment__char-count">{`${charCount || ''}/${textAreaMaxLength}`}</span> | |||
There was a problem hiding this comment.
Instead of an empty string, this should just be 0
There was a problem hiding this comment.
Oh sure, missed that one.
|
@danielcaldas for the PR! Can we show you some appreciation? Make sure to check out https://lbry.tech/contribute and sign up for the dev mailing list at the bottom! Also, see https://lbry.com/news/hacktoberfest-2019 for the latest Hacktoberfest details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check all that apply to this PR using "x":
PR Type
What kind of change does this PR introduce?
#2859
What is the current behavior?
No information about character count. Also no limit on the textarea for comments.
What is the new behavior?
The new behavior is demonstrated in the below GIF.