Load language from OS #3180
Merged
Load language from OS #3180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kauffj
commented
Nov 5, 2019
src/ui/redux/actions/settings.js
Outdated
| fetch('https://lbry.com/i18n/get/lbry-desktop/app-strings/' + language + '.json') | ||
| .then(r => r.json()) | ||
| .then(j => { | ||
| window.i18n_messages[language] = j; |
There was a problem hiding this comment.
@seanyesmunt is there a technique we can use to force/always trigger a complete re-render when window.i18n_messages[language] was not already set?
The only known time we are failing to re-render is when manually refreshing in app-mode.
There was a problem hiding this comment.
You can set a value in redux here, then pass that value in as a prop to the top level <App/> component
9 tasks
neb-b
approved these changes
Nov 5, 2019
| @@ -3,44 +3,27 @@ | |||
| import React, { useState } from 'react'; | |||
| import { FormField } from 'component/common/form'; | |||
| import Spinner from 'component/spinner'; | |||
| import { SETTINGS } from 'lbry-redux'; | |||
| import SUPPORTED_LANGUAGES from '../../constants/supported_languages'; | |||
kauffj
force-pushed
the
peterjgrainger-master
branch
from
9081083
to
5aa09b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves #3018 to allow
ui.jsto load immediately without waiting for language files to load.