Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dirty, unacceptable image rendering #3317

Merged
merged 5 commits into from
Jan 13, 2020
Merged

Conversation

kauffj
Copy link
Member

@kauffj kauffj commented Dec 3, 2019

your rejection is requested

see a clean/fast way to get this working on desktop?

@neb-b neb-b force-pushed the claim_preview_image_render branch from c949f1b to fca623c Compare January 7, 2020 20:30
@neb-b neb-b force-pushed the claim_preview_image_render branch from fca623c to 38e7f9f Compare January 7, 2020 21:07
Copy link
Member Author

@kauffj kauffj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice design! I can't approve since it's technically still my PR.

@neb-b neb-b force-pushed the claim_preview_image_render branch from a1c7338 to 098affe Compare January 8, 2020 16:37
@tzarebczan
Copy link
Contributor

Let Sean know this was still trying to download the thumbs we were hiding.

        "address": "bFFR9aqXaamuihY8mowejqHWHgyjktx2nm",
        "amount": "0.01",
        "canonical_url": "lbry://pPlAE0gEg4weOBTEDaSYsjaB#c",
        "claim_id": "c017e9ba992237a445494bf587dbb8c06e305cf4",
        "claim_op": "create",
        "confirmations": 10,
        "height": 696214,
        "meta": {
          "activation_height": 696214,
          "creation_height": 696214,
          "creation_timestamp": 1578522875,
          "effective_amount": "0.01",
          "expiration_height": 2798614,
          "is_controlling": true,
          "reposted": 0,
          "support_amount": "0.0",
          "take_over_height": 696214,
          "trending_global": 0.0,
          "trending_group": 0,
          "trending_local": 0.0,
          "trending_mixed": 0.0
        },
        "name": "pPlAE0gEg4weOBTEDaSYsjaB",
        "normalized_name": "pplae0geg4weobtedasysjab",
        "nout": 0,
        "permanent_url": "lbry://pPlAE0gEg4weOBTEDaSYsjaB#c017e9ba992237a445494bf587dbb8c06e305cf4",
        "short_url": "lbry://pPlAE0gEg4weOBTEDaSYsjaB#c",
        "timestamp": 1578522875,
        "txid": "8cabf4c8011facbf4c3edf658f92dba4dc331b13cd558b9614ad33c3acc576e1",
        "type": "claim",
        "value": {
          "author": "Spee.ch",





2020-01-08 18:00:51,634 INFO     lbry.stream.managed_stream:481: stopping inactive download for lbry://pPlAE0gEg4weOBTEDaSYsjaB#c017e9ba992237a445494bf587dbb8c06e305cf4 (ab5464...)`

@neb-b neb-b merged commit eab7807 into master Jan 13, 2020
@neb-b neb-b deleted the claim_preview_image_render branch January 13, 2020 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants