-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dirty, unacceptable image rendering #3317
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neb-b
force-pushed
the
claim_preview_image_render
branch
from
December 10, 2019 17:07
55cdaae
to
45aca61
Compare
neb-b
force-pushed
the
claim_preview_image_render
branch
from
January 7, 2020 19:22
bdea978
to
599feae
Compare
neb-b
force-pushed
the
claim_preview_image_render
branch
from
January 7, 2020 20:30
c949f1b
to
fca623c
Compare
neb-b
force-pushed
the
claim_preview_image_render
branch
from
January 7, 2020 21:07
fca623c
to
38e7f9f
Compare
kauffj
commented
Jan 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice design! I can't approve since it's technically still my PR.
neb-b
force-pushed
the
claim_preview_image_render
branch
from
January 8, 2020 16:37
a1c7338
to
098affe
Compare
Let Sean know this was still trying to download the thumbs we were hiding.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
your rejection is requested
see a clean/fast way to get this working on desktop?