Don't Show Edit Screen for Other Channels #3470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! 🎆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check all that apply to this PR using "x":
PR Type
What kind of change does this PR introduce?
Fixes
Issue Number: #3306
What is the current behavior?
When a user is editing their own channel and clicks on a channel they're subscribed to, it looks like they're editing the channel they don't own. This appears to only happen if the other channel is already "cached" (if user has already clicked on this channel during app execution).
Editing own channel
"Editing" other user's channel
What is the new behavior?
Once you click on a channel you don't own, you'll be taken out of editing.
Other information
@kcseb mentions the possibility of prompting a user to save or discard their changes. If this is preferred over just navigating to the selected channel (current behavior), I'd be happy to add this.