Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: appimage + cookie #3497

Merged
merged 3 commits into from
Jan 21, 2020
Merged

feat: appimage + cookie #3497

merged 3 commits into from
Jan 21, 2020

Conversation

tzarebczan
Copy link
Contributor

Made comments in areas that need some love to transfer existing tokens into a cookie. We may not even have to delete the old one, but we can if we want to clean em up (we'd need to use some of the functions I removed).

@tzarebczan tzarebczan requested a review from neb-b January 15, 2020 14:04
tzarebczan and others added 2 commits January 21, 2020 09:48
@neb-b neb-b merged commit 5d82b3c into master Jan 21, 2020
@neb-b neb-b deleted the appimage+cookie branch January 21, 2020 14:50
@neb-b neb-b mentioned this pull request Jan 21, 2020
Closed
probonopd added a commit to AppImage/appimage.github.io that referenced this pull request Jan 21, 2020
@probonopd
Create LBRY
608f396 
lbryio/lbry-desktop#3497
@probonopd probonopd mentioned this pull request Jan 21, 2020
Merged
@probonopd
Copy link

probonopd commented Jan 21, 2020 •
edited

Thanks for making an AppImage. Is there any chance you could bundle libsecret-1.so.0 as well?

Right now I am getting:

Error: libsecret-1.so.0: cannot open shared object file: No such file or directory

    at process.module.(anonymous function) [as dlopen] (ELECTRON_ASAR.js:160:31)

    at Object.Module._extensions..node (internal/modules/cjs/loader.js:722:18)

    at Object.module.(anonymous function) [as .node] (ELECTRON_ASAR.js:169:18)

    at Module.load (internal/modules/cjs/loader.js:602:32)

    at tryModuleLoad (internal/modules/cjs/loader.js:541:12)

    at Function.Module._load (internal/modules/cjs/loader.js:533:3)

    at Module.require (internal/modules/cjs/loader.js:640:17)

    at require (internal/modules/cjs/helpers.js:20:18)

    at Object.<anonymous> (/run/firejail/appimage/.appimage-9549/resources/app.asar/node_modules/keytar/lib/keytar.js:1:169)

    at Object.<anonymous> (/run/firejail/appimage/.appimage-9549/resources/app.asar/node_modules/keytar/lib/keytar.js:61:3)

References:

@tzarebczan
Copy link
Contributor Author

We plan to go away from using keytar, but we need to keep it for legacy users. Do you have a reference on how to bundle that easily with electron-builder?

@probonopd
Copy link

probonopd commented Jan 21, 2020 •
edited

Supposedly extraFiles can be used but I am not an electron-builder expert, so best ask in that thread in case you can't get it to work:

electron-userland/electron-builder#2732

probonopd added a commit to AppImage/appimage.github.io that referenced this pull request Jun 18, 2023
@probonopd
Create LBRY (#1890)
d17cc36 
* Create LBRY

lbryio/lbry-desktop#3497

* Update LBRY
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neb-b neb-b Awaiting requested review from neb-b

Assignees

@neb-b neb-b

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tzarebczan @probonopd @neb-b