Clear the internal file selector after clearPublish
#3500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Yamboy1 nice fix. There is also a similar problem with choosing the thumbnail if you follow these steps.
This leaves us in the state similar to the one you fixed for the file selection. Modal from step 2 |
|
I'll see if I can add that in. Thanks @dalhill |
|
In it's current state, I can't seem to find a way to do this that doesn't break the publish entirely, so I'm going to leave that out of this PR for now. Feel free to make another issue from that tho |
|
Nice! 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check all that apply to this PR using "x":
PR Type
What kind of change does this PR introduce?
Fixes
Issue Number: #3490
What is the current behavior?
If you select a file (on the publish screen), then clear the form and try to select it again, it won't select
What is the new behavior?
You are able to select it on the second try now.
Other information
I've checked that these changes don't break any other places that the FileSelector component is used.