Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3502 by Changing the Way We 'Queue' Search Queries #3503

Merged
merged 1 commit into from
Jan 16, 2020

Conversation

dalhill
Copy link
Contributor

@dalhill dalhill commented Jan 16, 2020

PR Checklist

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change

PR Type

  • Bugfix

Fixes

Issue Number: #3502

What is the current behavior?

When searching for content within a specific channel, the channel ID for the query gets "stuck". The search results returned will be equal to the last unique channel visit.

Ex.
User views channels A -> B -> C -> D -> E. At this point if the user uses the search field for channels A, B, C or D they'll see results for channel E.

Steps to reproduce:

  1. View channel JordanBPeterson
  2. Search channel content using the word "oh"
  3. (observe expected) Results shown for only channel JordanBPeterson
  4. View channel JohnStossel
  5. View channel JordanBPeterson
  6. Search channel content using the word "oh"
  7. (observe bug) - Results shown for channel JohnStossel

What is the new behavior?

The search will only return content that belongs to the channel being viewed.

Other information

Image of Search Field in Question
search-field

@neb-b neb-b merged commit 8df1e3f into lbryio:master Jan 16, 2020
@neb-b
Copy link

neb-b commented Jan 16, 2020

Woohoo! Keep em coming! 😛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants