Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add footer for web #4159

Merged
merged 4 commits into from May 13, 2020
Merged

add footer for web #4159

merged 4 commits into from May 13, 2020

Conversation

neb-b
Copy link

@neb-b neb-b commented May 8, 2020 •
edited

Screen Shot 2020-05-08 at 12 59 29 PM

@neb-b neb-b marked this pull request as ready for review May 8, 2020 16:59
@neb-b
Copy link
Author

neb-b commented May 8, 2020

@kauffj this is ready once the links are figured out. I wasn't sure exactly what to put.

@neb-b neb-b requested a review from kauffj May 8, 2020 17:00
@lbry-bot lbry-bot assigned kauffj and unassigned neb-b May 8, 2020
kauffj
kauffj approved these changes May 12, 2020
View reviewed changes
ui/scss/component/_footer.scss Outdated
padding: var(--spacing-medium);

flex-direction: column;
> * {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's mildly better to just give this a class.

@lbry-bot lbry-bot assigned neb-b and unassigned kauffj May 12, 2020
@neb-b neb-b merged commit 5af0cfc into master May 13, 2020
@neb-b neb-b deleted the footer branch May 13, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kauffj kauffj kauffj approved these changes

Assignees

@neb-b neb-b

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@neb-b @kauffj