New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch for comicbook viewer #4161
Conversation
How can I bypass this error / warning? |
I tried to test it on the web version but it's just stuck on loading, probably because of the file size ?
hmm actually, this just takes a few seconds: |
Now I can't load any content on the dev server 🙃 Also let me know if I need to update the change log with this changes or any of the recent pull request. |
Thanks for this @btzr-io! I'll mess around with trying this on web with different file types, but I think this can be merged before that. Can you rebase and add a changelog entry? |
Ok, done. |
@btzr-io There is still a conflict. Can you rebase? |
@seanyesmunt ok, hmm I don't see any conflicts on the |
Hm. Ok don't worry about it. I'll check it out and merge in a little bit. |
74b3444
to
74e85ed
Compare
@seanyesmunt I think I fixed the conflicts |
Use this effect instead of the "file://" protocol
- convert to functional component - use hooks to load stream
Use this on the web for files that need to wait for the full stream
always show viewer: fix #4141 minor improvements for loading indicator
PR Checklist
Please check all that apply to this PR using "x":
PR Type
What kind of change does this PR introduce?
Changes
Other information
This or similar files should not longer fail to load:
lbry://144BlackestNightby01GreenLantern43Prologuecbz#b