Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch for comicbook viewer #4161

Merged
merged 8 commits into from May 13, 2020
Merged

Patch for comicbook viewer #4161

merged 8 commits into from May 13, 2020

Conversation

btzr-io
Copy link
Collaborator

@btzr-io btzr-io commented May 8, 2020

PR Checklist

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

Changes

Other information

This or similar files should not longer fail to load:
lbry://144BlackestNightby01GreenLantern43Prologuecbz#b

Note this changes can be use on any nonstream files like 3D to be displayed on the web, using the new stream hooks to get a blob.

@btzr-io
Copy link
Collaborator Author

btzr-io commented May 8, 2020

How can I bypass this error / warning?
dearrrfish/preprocess-loader#14

@btzr-io btzr-io marked this pull request as ready for review May 9, 2020 03:45
@btzr-io
Copy link
Collaborator Author

btzr-io commented May 9, 2020

I tried to test it on the web version but it's just stuck on loading, probably because of the file size ?
Anyway it should be really easy to enable now, just remove COMIC from this line:

export const UNSUPPORTED_IN_THIS_APP = IS_WEB ? [CAD, COMIC, APPLICATION] : [APPLICATION, PDF];

hmm actually, this just takes a few seconds:
https://cdn.lbryplayer.xyz/content/claims/144BlackestNightby01GreenLantern43Prologuecbz/b985c86770ac1c52e8b03842f9cee73f9b97b3b2/stream

@btzr-io
Copy link
Collaborator Author

btzr-io commented May 9, 2020

Now I can't load any content on the dev server 🙃
I'll need help testing on the web version if that's a feature that should be added

Also let me know if I need to update the change log with this changes or any of the recent pull request.

@neb-b neb-b self-requested a review May 11, 2020 13:33
@lbry-bot lbry-bot assigned neb-b and unassigned neb-b May 11, 2020
@neb-b
Copy link

neb-b commented May 11, 2020

Thanks for this @btzr-io!

I'll mess around with trying this on web with different file types, but I think this can be merged before that. Can you rebase and add a changelog entry?

@btzr-io
Copy link
Collaborator Author

btzr-io commented May 11, 2020

Ok, done.

@neb-b
Copy link

neb-b commented May 11, 2020

@btzr-io There is still a conflict. Can you rebase?

@btzr-io
Copy link
Collaborator Author

btzr-io commented May 11, 2020

@seanyesmunt ok, hmm I don't see any conflicts on the github UI 🤔

@neb-b
Copy link

neb-b commented May 11, 2020

Hm. Ok don't worry about it. I'll check it out and merge in a little bit.

@btzr-io btzr-io force-pushed the patch-nonstream-1 branch 2 times, most recently from 74b3444 to 74e85ed Compare May 12, 2020 01:24
@btzr-io
Copy link
Collaborator Author

btzr-io commented May 13, 2020

@seanyesmunt I think I fixed the conflicts

Use this effect instead of the "file://" protocol
- convert to functional component
- use hooks to load stream
Use this on the web for files that need to wait for the full stream
always show viewer: fix #4141

minor improvements for loading indicator
@neb-b neb-b merged commit e063363 into master May 13, 2020
@neb-b neb-b deleted the patch-nonstream-1 branch May 13, 2020 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants