bring in email preferences page from lbry.com #4409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kauffj This works when signed in, or if a
|
neb-b
force-pushed
the
email-notifications-page
branch
from
1d5b1bf
to
587c1a1
Compare
kauffj
reviewed
Jun 19, 2020
| /> | ||
| <> | ||
| <Card | ||
| title={__('Notifications')} |
There was a problem hiding this comment.
maybe we could introduce tabs to settings instead of this? (not blocking feedback, can evolve)
There was a problem hiding this comment.
Yeah. This definitely a step towards some tabbed/nested setting page.
kauffj
reviewed
Jun 19, 2020
| {enabledEmails.map(({ email, isEnabled }) => ( | ||
| <FormField | ||
| type="checkbox" | ||
| name={`active-email:${email}`} |
There was a problem hiding this comment.
is this safe for all potential emails?
There was a problem hiding this comment.
Yeah. It's just used for the input label for screen readers
|
|
||
| {enabledEmails && enabledEmails.length > 0 && ( | ||
| <Card | ||
| title={__('Receiving Addresses')} |
There was a problem hiding this comment.
many people will have one email, probably worth making this conditional
There was a problem hiding this comment.
That's a good point. Will change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The notifications PR was already pretty big so I decided to strip this out and make a PR for this separately.