Fix "Price=free" giving 0 results in Following query #4489
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding changelog (assuming fix is correct): |
## Issue Fixes 4477 ## Remarks I didn't consult the documentation, but simply did a trial-and-error. "=0" -- didn't work "<=0" -- works
infinite-persistence
force-pushed
the
#4477-free-results
branch
from
822a896
to
a4797dd
Compare
|
Hmm, mine is working on master with just =0. On one of my accounts, I did see a query timeout...let me track that down. Maybe that's what you were seeing and not 0 results. I'm not sure how this fix would help...but maybe some strange sql quirk on the SDK. |
|
Closing this PR. Continuing discussion in the original Issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #4477
Remarks
I didn't consult the documentation, but simply did a trial-and-error.
"=0"-- didn't work"<=0"-- workDisclaimer
I have no idea what I'm doing, but it works. I have a feeling this might be an SDK problem.