Fix 'Related' section lazy-load not working in some scenarios #4586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neb-b
reviewed
Jul 27, 2020
| injectedItem={!isAuthenticated && IS_WEB && <Ads type="video" small />} | ||
| empty={__('No related content found')} | ||
| /> | ||
| <WaitUntilOnPage lastUpdateDate={this.lastReset}> |
There was a problem hiding this comment.
Should this prop be added to the WaitUntilOnPage wrapper around CommentList?
There was a problem hiding this comment.
Ah, missed it. For some reason, I kept thinking that one is the Channel Comments.
There are cases where `WaitUntilOnPage` will incorrectly render, such as at the beginning if the upper components hasn't expanded to full size, so `WaitUntilOnPage` would be briefly visible. Added a 300ms debounce to fix this, which would also improve scrolling performance a bit by doing less. Hopefully 300ms is enough for the upper components to inflate to full size.
…stead. This allows `RecommendedContent` to render the Card but with an empty list, so that the area isn't totally blank while waiting for `WaitUntilOnPage` to debounce.
## Issue In the `Autoplay` case, if the `WaitUntilOnPage` has already opened the gates previously, the next video's Related will be loaded regardless of scroll position. ## Changes Add a `lastUpdateDate` prop to `WaitUntilOnPage` to allow the parent to reset the gating state. I don't really like the `lastUpdateDate` prop since it's purpose is not intuitive. Is there a standard way to do a "one-time trigger" from the parent?
infinite-persistence
force-pushed
the
ip-related-gating
branch
from
9e54110
to
ceab27d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
WaitUntilOnPagehas already opened the gates previously, the next video's Related Section will be loaded regardless of scroll position.Changes
See the commit messages for the walkthrough.
Comments
Using the debounce method doesn't fix the first issue 100%, but it covers most cases with a decent connection speed. In the future, I'm thinking of using a dummy placeholder component with typical Video height while waiting for Images to load.