Tip Modal: Don't do final submit when the intention is to create New Channel. #4629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infinite-persistence
force-pushed
the
ip-tip-modal-new-channel-4544
branch
from
3303bcf
to
30f9247
Compare
…Channel. ## Issue Fixes `4544 Channel-creation in "Tip|Support" Modal shouldn't submit LBC immediately` ## Changes `Form` seems to have already tried to stop the propagation of `onSubmit`, so I'm not sure why it was still propagated. Fix by using the same method used in the `CommentCreate`, which is simply to check for `CHANNEL_NEW` as the current selection.
neb-b
force-pushed
the
ip-tip-modal-new-channel-4544
branch
from
30f9247
to
d4e3e6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #4544 Channel-creation in "Tip|Support" Modal shouldn't submit LBC immediately
Changes
Formseems to have already tried to stop the propagation ofonSubmit, so I'm not sure why it was still propagated.Fix by using the same method used in the
CommentCreate, which is simply to check forCHANNEL_NEWas the current selection.