Fix comment-creation failure if you have recently deleted a channel #4630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Issue Fixes `4621 Can't create Comments if you recently deleted a channel` The `channel` that the parent passes in is from a persisted state. If the channel has been deleted, `<select>` will automatically resolve to another selectable value. However, `onChange` will not be called for this scenario, so we now have a mismatch. ## Changes - Manually check if the value has been auto-resolved and report it to the parent. - An extra `setTimeout` was needed. It seems like `onChannelChange` needs to be called after the first `useEffect` of the parent, otherwise the call has no effect.
infinite-persistence
force-pushed
the
ip-comment-channel-mismatch-4621
branch
from
bafba18
to
58f60d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #4621 Can't create Comments if you recently deleted a channel
Fixes #3013 Impossible to add comments
The
channelthat the parent passes in is from a persisted state. If the channel has been deleted,<select>will automatically resolve to another selectable value. However,onChangewill not be called for this scenario, so we now have a mismatch.Changes
setTimeoutwas needed. It seems likeonChannelChangeneeds to be called after the firstuseEffectof the parent, otherwise the call has no effect.