Fix floating player being paused after dragging. #4710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infinite-persistence
force-pushed
the
ip-drag-pause-4709
branch
from
0a6ea28
to
461e239
Compare
## Issue Fixes 4709 `Dragging floating player via video section pauses video` ## Changes Don't propagate the key-up action if the window was dragged. Hopefully there isn't another sub-component that relies on the action being propagated. ## Note If you drag at exactly the "Play" icon the control bar, the issue still happens.
infinite-persistence
force-pushed
the
ip-drag-pause-4709
branch
from
461e239
to
33063e8
Compare
|
Nice one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #4709 Dragging floating player via video section pauses video
Changes
Don't propagate the key-up action if the window was dragged. Hopefully there isn't another sub-component that relies on the action being propagated.
Note
If you drag at exactly the "Play" icon the control bar, the issue still happens, though.