Web: Fix 'Download' not triggering until second attempt #4721
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #4669: Download doesn't trigger on web until 2nd attempt
The issue only happens when Autoplay is disabled in the User Settings and the video hasn't been loaded when Download is clicked.
The following code:
if (didClickDownloadButton && streamingUrl)
didn't triggered because:
streamingUrl
has not resolved yet when the Effect ran.didClickDownloadButton
to reset.Approach
boolean
tostring
, with the compared value being the currenturi
when the Download button was clicked.