Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another attempt at PR #4730
This includes the change suggested to fix the lingering bug from that commit.
PR Checklist
Please check all that apply to this PR using "x":
PR Type
What kind of change does this PR introduce?
Fixes
Issue Number: 4516
What is the current behavior?
Search query containing '%' causes app crash
What is the new behavior?
Searches can now contain '%' character
Other information
Api request was breaking for main search and autocomplete when query string included symbols such as '%' and whitespace.
The ClaimPreview component was also throwing an exception when the claim URI was invalid, causing the app to crash.
This PR fixes all of the above, and includes a minor refactor of the wunderbar component view/index.
I have hidden the URI header in the search page (which contains the ClaimPreview component, and a couple of URI-related links) for inavlid URIs.
The search functionality still logs an error to the console when the search string contains whitespace - this comes from directly calling
console.error(...)
in theparseURI
method (lbry-redux project). This should probably be improved at some point.Thanks!