Clear 'passwordSet*' flags too in USER_PASSWORD_SET_CLEAR #4766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Issue 4749: "Password updated successfully" kept showing up ## Change In addition to the `passwordReset*` variables, reset the `passwordSet*` variables as well for `USER_PASSWORD_SET_CLEAR`.
infinite-persistence
force-pushed
the
ip-password-toast-4749
branch
from
d17b8ad
to
5ee29a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #4749: "Password updated successfully" kept showing up
Change
In addition to the
passwordReset*variables, reset thepasswordSet*variables as well inUSER_PASSWORD_SET_CLEAR.Based on current usage, I think it's ok to re-use USER_PASSWORD_SET_CLEAR instead of creating another one to differentiate between Reset and Set?