Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDE: Replace the iframe with a stub in "edit + preview" mode. #4767

Merged
merged 1 commit into from
Sep 16, 2020

Conversation

infinite-persistence
Copy link
Contributor

Issue

Fixes #4644: Markdown Preview breaks when <iframe> is present

Error: "Invariant violation: could not find 'store' ..."

Change

Until we figure out a way to pass the store to the SimpleMDE preview formatter, just replace the embed with a stub region.

image

## Issue
4644: Markdown Preview breaks when <iframe> is present

Error: "Invariant violation: could not find 'store' ..."

## Change
Until we figure out a way to pass the store to the SimpleMDE preview formatter, just replace the embed with a stub region.
@neb-b neb-b merged commit dbcd677 into master Sep 16, 2020
@neb-b neb-b deleted the ip-mde-embed-4644 branch September 16, 2020 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markdown Preview breaks when <iframe> is present
2 participants