Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shift enter to comment #4809

Merged
merged 2 commits into from
Oct 2, 2020
Merged

shift enter to comment #4809

merged 2 commits into from
Oct 2, 2020

Conversation

jessopb
Copy link
Member

@jessopb jessopb commented Sep 30, 2020

No description provided.

@jessopb jessopb requested a review from neb-b September 30, 2020 18:07
neb-b
neb-b suggested changes Oct 1, 2020
View reviewed changes
Copy link

@neb-b neb-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment. Trying to figure out some component rules and I think it's helpful to have refs at the very top to quickly tell there are refs somewhere in a component.

ui/component/commentCreate/view.jsx Outdated
@@ -65,13 +67,26 @@ export function CommentCreate(props: Props) {
function handleCommentAck() {
setCommentAck(true);
}
const buttonref: ElementRef<any> = React.useRef();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this to the top of the component, above any useState uses

@neb-b neb-b merged commit ec3a763 into master Oct 2, 2020
@neb-b neb-b deleted the feat-shiftEnterComment branch October 2, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neb-b neb-b neb-b requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jessopb @neb-b