Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat sort pinned to top #4895

Merged
merged 2 commits into from
Oct 19, 2020
Merged

Feat sort pinned to top #4895

merged 2 commits into from
Oct 19, 2020

Conversation

jessopb
Copy link
Member

@jessopb jessopb commented Oct 14, 2020

@jessopb jessopb requested a review from neb-b October 14, 2020 20:45
neb-b
neb-b suggested changes Oct 14, 2020
View reviewed changes
Copy link

@neb-b neb-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment. I pushed up a commit that tweaks the pin icon since it was messed up a bit

ui/component/comment/index.js Outdated Show resolved Hide resolved
@jessopb
comment pin action
e18ed87 
owners can pin and unpin comments

tweak pin icon styles

move commenting activeChannel from localStorage to redux
@jessopb
bump
70598b8
@neb-b neb-b merged commit 0249e62 into master Oct 19, 2020
@neb-b neb-b deleted the feat-sortPinnedToTop branch October 19, 2020 18:48
@neb-b neb-b mentioned this pull request Oct 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neb-b neb-b neb-b requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jessopb @neb-b