Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat language search #4907

Merged
merged 2 commits into from
Oct 29, 2020
Merged

Feat language search #4907

merged 2 commits into from
Oct 29, 2020

Conversation

jessopb
Copy link
Member

@jessopb jessopb commented Oct 15, 2020 •
edited

claimSearch by language
setting to constrain search to language in settings
channel update for language (primary, secondary)

@jessopb
Copy link
Member Author

jessopb commented Oct 16, 2020

lbryio/lbry-redux#358

@jessopb jessopb marked this pull request as ready for review October 16, 2020 22:02
@jessopb jessopb requested a review from neb-b October 19, 2020 01:44
neb-b
neb-b suggested changes Oct 22, 2020
View reviewed changes
Copy link

@neb-b neb-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should only add these languages for the drop down. All the others time out every time for me, even when sorting by new

English
Hrvatski
Nederlands
Francais
Deutsch
Italiano
Polski
Portugues
Pyccknn
Espanol
Turkce
Cesky

@jessopb
claim-search by language
ef64735 
setting to search only in language as default

add channel update language selection and about

bump

searchable languages
@jessopb jessopb requested a review from neb-b October 29, 2020 17:44
@neb-b neb-b merged commit 734e08a into master Oct 29, 2020
@neb-b neb-b deleted the feat-languageSearch branch October 29, 2020 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neb-b neb-b Awaiting requested review from neb-b

Assignees

@neb-b neb-b

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jessopb @neb-b