Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed regression in #501 #507

Merged
merged 1 commit into from Aug 28, 2017
Merged

Conversation

hackrush01
Copy link
Contributor

@hackrush01 hackrush01 commented Aug 27, 2017

  • Beat @wallermadev to the PR
  • Fix the regression

This is a temporary fix, but I think the daemon should return consistent result whether it be file_list or claim_list_mine.

@hackrush01 hackrush01 added type: bug Existing functionality is wrong or broken P1 labels Aug 27, 2017
@hackrush01 hackrush01 requested a review from kauffj August 27, 2017 05:11
@MatWaller
Copy link
Contributor

Haha -- Cheers mate, boxing go
It in the way will do build on windows/Linux and test now.

@hackrush01
Copy link
Contributor Author

@wallermadev How do you build it for windows?

@MatWaller
Copy link
Contributor

I would be more than happy to add a wiki page to the lbry-app repository as this will probably be useful.

I have tested your fix both with and without items published on the following operating systems;

  • Windows 10 (Working)
  • Ubuntu Budgie (Working)

@kauffj Seems to all work fine.

W

@kauffj kauffj merged commit 3f7391f into lbryio:master Aug 28, 2017
@kauffj
Copy link
Member

kauffj commented Aug 28, 2017

@wallermadev adding Windows build instructions to the README would be much appreciated

@hackrush01 hackrush01 deleted the regression-fix-501 branch August 29, 2017 07:40
@MatWaller
Copy link
Contributor

@kauffj 566 Added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Existing functionality is wrong or broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants