Fix unnecessary livestream api calls in channel page #6652
Conversation
|
|
||
| React.useEffect(() => { | ||
| if (livestreamChannelId) { | ||
| // Don't search empty channels | ||
| if (livestreamChannelId && !isChannelEmpty) { | ||
| Lbry.claim_search({ |
There was a problem hiding this comment.
Nice.
This might be faster with page_size=1 and no_totals?
@tzarebczan
There was a problem hiding this comment.
Is there any difference between claim_list and claim_search ?
https://lbry.tech/api/sdk#claim_list
There was a problem hiding this comment.
claim list is specifically one's own publishes.
There was a problem hiding this comment.
page=1 is a given - page_size=1 would limit results. Not sure how big of a deal it would be.
There was a problem hiding this comment.
Can you publish something while livestreaming ?
I think will be safer to check more than one claim.
There was a problem hiding this comment.
the "has no source param" ensures it's only the live streams that are returned. And right now we use the latest one you have published.
|
Changelog update: #6735 |
|
Any reason for not merging this yet ? |
PR Checklist
Please check all that apply to this PR using "x":
PR Type
What kind of change does this PR introduce?
Fixes
Issue Number: #6632
Changelog update: #6735