use default path in windows when choosing a file #7625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessopb
approved these changes
Jun 24, 2022
| @@ -47,7 +47,24 @@ class FileSelector extends React.PureComponent<Props> { | |||
| }; | |||
|
|
|||
| handleDirectoryInputSelection = () => { | |||
| remote.dialog.showOpenDialog({ properties: ['openDirectory'] }).then((result) => { | |||
| var defaultPath; | |||
There was a problem hiding this comment.
Just a minor nitpick, but it's usually better to use let when you can.
| properties = ['openDirectory']; | ||
| } | ||
|
|
||
| remote.dialog.showOpenDialog({ properties, defaultPath }).then((result) => { |
There was a problem hiding this comment.
nice,
tested in console in linux
x = require('@electron/remote')
x.dialog.showOpenDialog({properties: ['openFile'], defaultPath: undefined})
And it worked fine.
jessopb
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Issue Number: #1811
What is the current behavior?
Currently the "Choose File" button opens the root folder of the program and not "My documents" or "My computer" which generates confusion in new users, this error only happens in windows.
What is the new behavior?
Clicking on the "Choose File" button opens the user's root folder.
Other information
PR Checklist
Toggle...
What kind of change does this PR introduce?
Please check all that apply to this PR using "x":