Video overlay #825
Video overlay #825
Conversation
hackrush01
force-pushed
the
video-overlay
branch
from
687c521
to
1da82cc
Compare
| return ( | ||
| <div className="video__loading-screen"> | ||
| <div> | ||
| {spinner && <div className="video__loading-spinner" />} |
There was a problem hiding this comment.
This should use the <Spinner /> component
There was a problem hiding this comment.
I noticed one thing. We already have a common.js file here(file 1), but the <Spinner /> component comes from here(folder 1), a new common folder with just that component.
Are we breaking down file 1 to individual components and putting them in folder 1? Or should I include <Spinner /> component in file 1. The latter option is better IMO as then we don't have to include different files for each "common" component, unless former is better for some use cases.
There was a problem hiding this comment.
@hackrush01 @seanyesmunt @liamcardenas I think common.js should die and these should all just be individual components.
|
This is on hold. When we're ready to work on this, we should re-evaluate and figure out the right approach. |
No description provided.