Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot update claims larger than wallet balance #748

Closed
kauffj opened this issue Jun 30, 2017 · 6 comments
Closed

Cannot update claims larger than wallet balance #748

kauffj opened this issue Jun 30, 2017 · 6 comments
Assignees
@hackrush01
Labels
area: wallet Epic level: 2 Some knowledge of the existing code is recommended Tom's Wishlist type: bug Existing functionality is wrong or broken

Comments

@kauffj
Copy link
Member

kauffj commented Jun 30, 2017

Originally lbry-app #117
@kauffj kauffj added type: bug Existing functionality is wrong or broken P2 labels Jun 30, 2017
@kauffj kauffj mentioned this issue Jun 30, 2017
Closed
@tzarebczan
Copy link
Contributor

An option for the user during claim update would make sense if it's technically possible.

@kauffj
Copy link
Member Author

kauffj commented Jun 30, 2017

An option would exist at the app/UI level, not the API level.

@kaykurokawa kaykurokawa mentioned this issue Jul 13, 2017
Closed
@tzarebczan
Copy link
Contributor

This is a pretty big UX issue at the moment, maybe we can bump the priority @kauffj

We would need @kaykurokawa 's fixes from #747 which would allow the daemon to realize that it can use the original deposit amount during an update. So really only any difference in LBC (in case they are increasing the bid) needs to be in your balance (plus tx fees obviously).

@tzarebczan
Copy link
Contributor

@lyoshenka anyway we can bump this up the queue? Sounds like it would need some lbryum changes too.

@tzarebczan tzarebczan mentioned this issue Dec 12, 2017
Closed
@hackrush01 hackrush01 self-assigned this Dec 22, 2017
@hackrush01
Copy link
Contributor

hackrush01 commented Dec 22, 2017 •
edited

I am assigning it to myself currently, as I think I should be able to solve it.

@tzarebczan
Copy link
Contributor

Thanks @hackrush01 . This might be related, or at least part of the same code, please keep it in mind: #855

@lyoshenka lyoshenka added needs level level: 2 Some knowledge of the existing code is recommended area: wallet and removed needs labels labels Jan 9, 2018
@lyoshenka lyoshenka mentioned this issue Jan 23, 2018
Closed
This was referenced Jan 26, 2018
Closed
Closed
hackrush01 added a commit that referenced this issue Feb 8, 2018
@hackrush01
Removed daemon side bid checks during publish
c45fc2e 
Fixes #748
@hackrush01 hackrush01 mentioned this issue Feb 13, 2018
Merged
hackrush01 added a commit that referenced this issue Feb 14, 2018
@hackrush01
Removed daemon side bid checks during publish
41543a9 
Fixes #748

Fixed failing test, Yay!

Why CHANGELOG? Why not anarchy?
@tzarebczan tzarebczan mentioned this issue Mar 12, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hackrush01 hackrush01

Labels
area: wallet Epic level: 2 Some knowledge of the existing code is recommended Tom's Wishlist type: bug Existing functionality is wrong or broken
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lyoshenka @kauffj @tzarebczan @hackrush01