Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor lbrynet-daemon into modular components #1164

Merged
merged 37 commits into from
Jul 5, 2018
Merged

refactor lbrynet-daemon into modular components #1164

merged 37 commits into from
Jul 5, 2018

Conversation

jackrobison
Copy link
Member

No description provided.

@lbryio lbryio deleted a comment Apr 10, 2018
@tzarebczan
Copy link
Contributor

@hackrush01 will you be using this PR or can we close it?

@lbryio lbryio deleted a comment Apr 20, 2018
@lbryio lbryio deleted a comment Apr 20, 2018
@hackrush01
Copy link
Contributor

@tzarebczan I'll be using this.

@lbryio lbryio deleted a comment Apr 22, 2018
jackrobison
jackrobison commented Apr 23, 2018
View reviewed changes
Copy link
Member Author

@jackrobison jackrobison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hackrush01

The wallet component looks good.

Next, you should add a dht_node component to used by Session (if a Node object is provided as an argument Session should use it instead of making one and starting it). Once you've got the dht_node component, Session can be made into a component too, followed by the file manager.

lbrynet/daemon/Daemon.py Outdated
d.addCallback(create_session)
return defer.succeed(True)

d = create_session(self.wallet)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create_session doesn't need to be a function, you can just return self.session.setup() instead of having a callback.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

lbrynet/daemon/Daemon.py Outdated
migrated = yield self._check_db_migration()
yield self.storage.setup()
yield self.component_manager.setup()
self.storage = self.component_manager.get_component("database").storage
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hackrush01 you can remove this since you've removed the references to Daemon.storage (to use Daemon.session.storage)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self.storage is still needed here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed in the latest commit

@lbryio lbryio deleted a comment Apr 28, 2018
@hackrush01 hackrush01 assigned hackrush01 and unassigned jackrobison Apr 29, 2018
@lbry-bot lbry-bot assigned jackrobison and unassigned hackrush01 Apr 29, 2018
@lbryio lbryio deleted a comment Apr 29, 2018
@hackrush01
Copy link
Contributor

hackrush01 commented May 17, 2018 •
edited

6327c0d also fixes a regression which caused blobfiles folder to be created in the github repo as opposed to the .lbrynet folder

pylint error will be fixed in the next commit

@lbryio lbryio deleted a comment May 17, 2018
@hackrush01 hackrush01 assigned hackrush01 and unassigned jackrobison May 18, 2018
@hackrush01
Fixed test_streamify(well Jack did, but ¯\_(ツ)_/¯)
69679b5
@hackrush01
All tests now passing
cdba205
@hackrush01
Pylint fixes
c081f25
@hackrush01
Oops(That's all you're gonna get :-P)
b99f7a1
@hackrush01
Making decorators(WIP, commit so that I don't lose work)
5550e94
@hackrush01
Decorator made and decorating of functions done(some other changes)
a300b23
@hackrush01
import fixes and removed temporary test function
c1c7d2f
@hackrush01
Fixed new broken tests from daemon refactor
b0a3902
@hackrush01
Sanitization of modules
24b48c6
@hackrush01
Reworded errors
8093eda
@hackrush01
wallet unlock condition checks, fixed breaking changes
2aa07a0
@hackrush01
Rebased on amster and other crazy stuff
0225ee6
@hackrush01
Started writing tests
d5eae25
@hackrush01
Tests for component manager
f5403e2
@hackrush01
Fix Daemon Tests
4e8d3dc
@hackrush01
Fixed passing mutable args in init
523d074
@hackrush01
Using constants instead of strings. Added CHANGELOG.md
888dc34
@hackrush01
Now components can be skipped by setting relevant config in file.
ab5fd64
This was referenced Jul 3, 2018
Closed
Closed
Closed
@eukreign eukreign merged commit 75a6ff2 into master Jul 5, 2018
@eukreign eukreign deleted the daemon-components branch July 5, 2018 19:22
@eukreign eukreign restored the daemon-components branch July 5, 2018 23:02
eukreign added a commit that referenced this pull request Jul 5, 2018
@eukreign
Revert "refactor lbrynet-daemon into modular components (#1164)"
2cca5fc 
This reverts commit 75a6ff2.
@eukreign eukreign mentioned this pull request Jul 5, 2018
Merged
eukreign added a commit that referenced this pull request Jul 5, 2018
@eukreign
Revert "refactor lbrynet-daemon into modular components" (#1286)
6952c2c 
* Revert "fix reflector test"

This reverts commit 6a15b51.

* Revert "refactor lbrynet-daemon into modular components (#1164)"

This reverts commit 75a6ff2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eukreign eukreign eukreign left review comments

@hackrush01 hackrush01 hackrush01 left review comments

Assignees

@jackrobison jackrobison

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jackrobison @tzarebczan @hackrush01 @eukreign