Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ported lbrynet.extras.daemon.analytics to asyncio #1745

Merged
merged 4 commits into from Jan 11, 2019
Merged

ported lbrynet.extras.daemon.analytics to asyncio #1745

merged 4 commits into from Jan 11, 2019

Commits on Jan 11, 2019

  1. Removes the twisted dependency from the analytics file and replaces it 

    with `asyncio` and `aiohttp`. Also removes the calling loop from the
analytics in favor of a `dict` that stores the names of the methods
and their coroutines that are wrapped inside a looping task. The tasks
are canceled when the analytics manager is asked to shutdown

Signed-off-by: Oleg Silkin <o.silkin98@gmail.com>
    @osilkin98 @eukreign
    osilkin98 authored and eukreign committed Jan 11, 2019
    Copy the full SHA
    aa5103b View commit details
    Browse the repository at this point in the history

  2. Modifies the unit tests for the analytics manager to have async routines 

    Signed-off-by: Oleg Silkin <o.silkin98@gmail.com>
    @osilkin98 @eukreign
    osilkin98 authored and eukreign committed Jan 11, 2019
    Copy the full SHA
    b3aa933 View commit details
    Browse the repository at this point in the history

  3. Removes await from shutdown call

    @osilkin98 @eukreign
    osilkin98 authored and eukreign committed Jan 11, 2019
    Copy the full SHA
    badb2ff View commit details
    Browse the repository at this point in the history

  4. looping_call shouldnt need to mess with cancellation

    @eukreign
    eukreign committed Jan 11, 2019
    Copy the full SHA
    647ed8d View commit details
    Browse the repository at this point in the history