Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop running streams after ten times the blob_download_timeout seconds of no read activity (not being saved or streamed) #2123

Merged
merged 3 commits into from May 10, 2019

Conversation

jackrobison
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented May 10, 2019

Codecov Report

Merging #2123 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2123      +/-   ##
==========================================
+ Coverage   78.14%   78.16%   +0.02%     
==========================================
  Files          96       96              
  Lines       10824    10834      +10     
==========================================
+ Hits         8458     8468      +10     
  Misses       2366     2366
Impacted Files Coverage Δ
lbrynet/dht/node.py 82.91% <ø> (+0.52%) ⬆️
lbrynet/stream/downloader.py 92.47% <100%> (ø) ⬆️
lbrynet/stream/managed_stream.py 92.12% <100%> (+0.26%) ⬆️
lbrynet/blob_exchange/server.py 85% <0%> (-4%) ⬇️
lbrynet/dht/protocol/iterative_find.py 83.88% <0%> (-0.42%) ⬇️
lbrynet/extras/daemon/Daemon.py 76.37% <0%> (+0.07%) ⬆️
lbrynet/extras/daemon/storage.py 82.38% <0%> (+0.51%) ⬆️
lbrynet/extras/daemon/analytics.py 88.54% <0%> (+1.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d2f592...ad2da24. Read the comment docs.

@jackrobison jackrobison requested a review from shyba May 10, 2019 18:58
@lbry-bot lbry-bot assigned shyba and unassigned jackrobison May 10, 2019
@jackrobison jackrobison merged commit 68ee31b into master May 10, 2019
@jackrobison jackrobison deleted the stop-timed-out-downloads branch May 10, 2019 19:29
@jackrobison jackrobison changed the title Stop timed out downloads stop running streams after ten times the blob_download_timeout seconds of no read activity (not being saved or streamed) May 14, 2019
@jackrobison jackrobison added area: files type: improvement Existing (or partially existing) functionality needs to be changed labels May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: files type: improvement Existing (or partially existing) functionality needs to be changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants