fixed is_valid_public_ipv4 not working correctly when ipv6 is given as address #2892
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When UPnP gives an ipv6 address to the function is_valid_public_ipv4, instead of return False, it throws an error:
This is because the checks doesn't stop when
parsed_ip.version != 4
, butCARRIER_GRADE_NAT_SUBNET.supernet_of(ipaddress.ip_network(f"{address}/32"))
andIPV4_TO_6_RELAY_SUBNET.supernet_of(ipaddress.ip_network(f"{address}/32")))
needs a valid IPv4 address.