Fix mimetypes for HLS streams, add mimetypes for segment files #3162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is just a minor improvement upon a much older contribution of mine: #2996 This modification would just make it slightly easier to implement some additional features related to livestreaming by removing some of the logic required to be client side. |
DispatchCommit
added
area: blobs/files
type: improvement
|
Looks good to me; can you rebase on master please? |
eukreign
force-pushed
the
fix/hls-dash-mimetypes
branch
from
6ade021
to
3047bb8
Compare
eukreign
added
type: improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix mimetype for HLS playlist .m3u8 file. Currently it returns an outdated vendor specific mimetype that has poor support and does not correctly identify in most modern browser.
Instead it should be replaced with the the generic x-mpegURL mimetype as this has wider support.
Also, add mimetypes for segment files, in case those are needed at some point in the future.